Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 6834004: Modify the way we pass the --results-directory to run_webkit_tests (Closed)

Created:
9 years, 7 months ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
caseq, M-A Ruel
CC:
chromium-reviews, tony, Nicolas Sylvain, Chris Rogers, pfeldman
Visibility:
Public.

Description

Modify the way we pass the --results-directory to run_webkit_tests In order to accomodate the fix in https://bugs.webkit.org/show_bug.cgi?id=58272, we will temporarily pass --results-directory as an absolute path. This fix needs to land *after* that fix. We will then land a subsequent fix to webkit.org changing the way relative paths are interpreted for chromium ports, and then remove the hack in this code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M scripts/slave/chromium/layout_test_wrapper.py View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dirk Pranke
9 years, 7 months ago (2011-04-12 22:51:25 UTC) #1
Dirk Pranke
(ping)
9 years, 7 months ago (2011-04-14 21:56:37 UTC) #2
M-A Ruel
GAE is dead; nit: you can use unconditionally: options.results_directory = os.path.abspath(options.results_directory) lgtm M-A Le 14 ...
9 years, 7 months ago (2011-04-14 22:30:20 UTC) #3
Dirk Pranke
I can now that NRWT supports absolute paths; previously, it didn't ;) -- Dirk On ...
9 years, 7 months ago (2011-04-14 22:48:40 UTC) #4
caseq
Apparently, now the directory we use for test results when running layout tests if different ...
9 years, 7 months ago (2011-04-15 13:09:40 UTC) #5
Dirk Pranke
9 years, 7 months ago (2011-04-15 18:54:56 UTC) #6
Whoops. Okay, I just landed a fix for this in r81772. Sorry!

On Fri, Apr 15, 2011 at 6:09 AM,  <caseq@chromium.org> wrote:
> Apparently, now the directory we use for test results when running layout
> tests
> if different from the one used in archiving test results.
> Example:
>
http://chromesshgw.corp.google.com/i/chromium.webkit/builders/Webkit%20Win/bu...
>
> (WebKit tests step)
>
> python.exe
>
e:\b\build\slave\Webkit_Win\build\src\webkit\tools\layout_tests\run_webkit_tests.py
> --noshow-results --verbose --full-results-html --clobber-old-results
> --results-directory e:\b\build\slave\layout-test-results --target Release
> --builder-name "Webkit Win" --build-number 3625 --master-name ChromiumWebkit
> --build-name Webkit_Win --build-directory
> e:\b\build\slave\Webkit_Win\build\src\webkit --test-results-server
> test-results.appspot.com ""
>
> (archive_webkit_tests_results step)
>
> Archiving results from e:\b\build\slave\Webkit_Win\build\layout-test-results
>
> This results in totally irrelevant test results being offered in build
> console.
>
>
> http://codereview.chromium.org/6834004/
>

Powered by Google App Engine
This is Rietveld 408576698