Modify the way we pass the --results-directory to run_webkit_tests

Modify the way we pass the --results-directory to run_webkit_tests

In order to accomodate the fix in https://bugs.webkit.org/show_bug.cgi?id=58272,
we will temporarily pass --results-directory as an absolute path.

This fix needs to land *after* that fix. We will then land a subsequent fix
to webkit.org changing the way relative paths are interpreted for chromium
ports, and then remove the hack in this code.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81662

[Dirk Pranke, 2011-04-14 21:56:37]

(ping)

[M-A Ruel, 2011-04-14 22:30:20]

GAE is dead;

nit: you can use unconditionally:
   options.results_directory = os.path.abspath(options.results_directory)

lgtm

M-A

Le 14 avril 2011 17:56, <dpranke@chromium.org> a écrit :

> (ping)
>
>
> http://codereview.chromium.org/6834004/
>

[Dirk Pranke, 2011-04-14 22:48:40]

I can now that NRWT supports absolute paths; previously, it didn't ;)

-- Dirk

On Thu, Apr 14, 2011 at 3:29 PM, Marc-Antoine Ruel <maruel@chromium.org> wrote:
> GAE is dead;
> nit: you can use unconditionally:
>    options.results_directory = os.path.abspath(options.results_directory)
>
> lgtm
> M-A
> Le 14 avril 2011 17:56, <dpranke@chromium.org> a écrit :
>>
>> (ping)
>>
>> http://codereview.chromium.org/6834004/
>
>

[caseq, 2011-04-15 13:09:40]

Apparently, now the directory we use for test results when running layout tests
if different from the one used in archiving test results.
Example:
http://chromesshgw.corp.google.com/i/chromium.webkit/builders/Webkit%20Win/bu...

(WebKit tests step)

python.exe
e:\b\build\slave\Webkit_Win\build\src\webkit\tools\layout_tests\run_webkit_tests.py
--noshow-results --verbose --full-results-html --clobber-old-results
--results-directory e:\b\build\slave\layout-test-results --target Release
--builder-name "Webkit Win" --build-number 3625 --master-name ChromiumWebkit
--build-name Webkit_Win --build-directory
e:\b\build\slave\Webkit_Win\build\src\webkit --test-results-server
test-results.appspot.com ""

(archive_webkit_tests_results step)

Archiving results from e:\b\build\slave\Webkit_Win\build\layout-test-results

This results in totally irrelevant test results being offered in build console.

[Dirk Pranke, 2011-04-15 18:54:56]

Whoops. Okay, I just landed a fix for this in r81772. Sorry!

On Fri, Apr 15, 2011 at 6:09 AM,  <caseq@chromium.org> wrote:
> Apparently, now the directory we use for test results when running layout
> tests
> if different from the one used in archiving test results.
> Example:
>
http://chromesshgw.corp.google.com/i/chromium.webkit/builders/Webkit%20Win/bu...
>
> (WebKit tests step)
>
> python.exe
>
e:\b\build\slave\Webkit_Win\build\src\webkit\tools\layout_tests\run_webkit_tests.py
> --noshow-results --verbose --full-results-html --clobber-old-results
> --results-directory e:\b\build\slave\layout-test-results --target Release
> --builder-name "Webkit Win" --build-number 3625 --master-name ChromiumWebkit
> --build-name Webkit_Win --build-directory
> e:\b\build\slave\Webkit_Win\build\src\webkit --test-results-server
> test-results.appspot.com ""
>
> (archive_webkit_tests_results step)
>
> Archiving results from e:\b\build\slave\Webkit_Win\build\layout-test-results
>
> This results in totally irrelevant test results being offered in build
> console.
>
>
> http://codereview.chromium.org/6834004/
>