Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 6833007: More filesystem cleanup: convert URL-encoded-as-FilePath to actual URL, where (Closed)

Created:
9 years, 8 months ago by ericu
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, jam, Erik does not do reviews, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, kinuko+watch
Visibility:
Public.

Description

More filesystem cleanup: convert URL-encoded-as-FilePath to actual URL, where possible without WebKit API changes. The WebKit changes will happen in another CL. This is a resubmit of http://codereview.chromium.org/6767010/, which bounced recently. There are a few changes here that weren't there [most notably in file_system_operation_write_unittest.cc and file_system_operation.cc], but they're pretty trivial build/test fixes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81463

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -548 lines) Patch
M chrome/browser/extensions/extension_file_browser_private_api.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_file_browser_private_api.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/file_system/file_system_dispatcher_host.h View 1 2 chunks +12 lines, -13 lines 0 comments Download
M content/browser/file_system/file_system_dispatcher_host.cc View 1 7 chunks +15 lines, -14 lines 0 comments Download
M content/common/file_system/file_system_dispatcher.h View 1 2 chunks +13 lines, -13 lines 0 comments Download
M content/common/file_system/file_system_dispatcher.cc View 1 11 chunks +14 lines, -14 lines 0 comments Download
M content/common/file_system/webfilesystem_callback_dispatcher.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/common/file_system/webfilesystem_callback_dispatcher.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/common/file_system/webfilesystem_impl.cc View 1 10 chunks +13 lines, -13 lines 0 comments Download
M content/common/file_system/webfilewriter_impl.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M content/common/file_system/webfilewriter_impl.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M content/common/file_system_messages.h View 1 3 chunks +13 lines, -13 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M webkit/fileapi/file_system_callback_dispatcher.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_file_util_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_operation.h View 1 3 chunks +16 lines, -16 lines 0 comments Download
M webkit/fileapi/file_system_operation.cc View 1 16 chunks +61 lines, -26 lines 0 comments Download
M webkit/fileapi/file_system_operation_unittest.cc View 1 47 chunks +66 lines, -55 lines 0 comments Download
M webkit/fileapi/file_system_operation_write_unittest.cc View 1 8 chunks +17 lines, -7 lines 0 comments Download
M webkit/fileapi/file_system_path_manager.h View 1 3 chunks +4 lines, -9 lines 0 comments Download
M webkit/fileapi/file_system_path_manager.cc View 1 2 chunks +23 lines, -77 lines 0 comments Download
M webkit/fileapi/file_system_path_manager_unittest.cc View 1 2 chunks +0 lines, -88 lines 0 comments Download
M webkit/fileapi/file_system_util.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M webkit/fileapi/file_system_util_unittest.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download
M webkit/fileapi/webfilewriter_base.h View 1 4 chunks +6 lines, -8 lines 0 comments Download
M webkit/fileapi/webfilewriter_base.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/webfilewriter_base_unittest.cc View 1 11 chunks +27 lines, -35 lines 0 comments Download
M webkit/plugins/ppapi/file_callbacks.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/file_callbacks.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/ppb_directory_reader_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 6 chunks +24 lines, -19 lines 0 comments Download
M webkit/plugins/ppapi/ppb_file_system_impl.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 1 2 chunks +14 lines, -36 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698