Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: webkit/fileapi/file_system_operation_write_unittest.cc

Issue 6833007: More filesystem cleanup: convert URL-encoded-as-FilePath to actual URL, where (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/fileapi/file_system_operation_unittest.cc ('k') | webkit/fileapi/file_system_path_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/file_system_operation_write_unittest.cc
===================================================================
--- webkit/fileapi/file_system_operation_write_unittest.cc (revision 81454)
+++ webkit/fileapi/file_system_operation_write_unittest.cc (working copy)
@@ -10,7 +10,6 @@
#include "webkit/fileapi/file_system_operation.h"
-#include "base/logging.h"
#include "base/message_loop.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_temp_dir.h"
@@ -61,6 +60,16 @@
virtual void TearDown();
protected:
+ GURL URLForRelativePath(const std::string& path) const {
+ // Only the path will actually get used.
+ return GURL("file://").Resolve(file_.value()).Resolve(path);
+ }
+
+ GURL URLForPath(const FilePath& path) const {
+ // Only the path will actually get used.
+ return GURL("file://").Resolve(path.value());
+ }
+
MessageLoop loop_;
ScopedTempDir dir_;
@@ -122,7 +131,7 @@
ADD_FAILURE();
}
- virtual void DidOpenFileSystem(const std::string&, const FilePath&) {
+ virtual void DidOpenFileSystem(const std::string&, const GURL&) {
ADD_FAILURE();
}
@@ -170,7 +179,7 @@
url_request_context->blob_storage_controller()->
RegisterBlobUrl(blob_url, blob_data);
- operation()->Write(url_request_context, file_, blob_url, 0);
+ operation()->Write(url_request_context, URLForPath(file_), blob_url, 0);
MessageLoop::current()->Run();
url_request_context->blob_storage_controller()->UnregisterBlobUrl(blob_url);
@@ -190,7 +199,7 @@
url_request_context->blob_storage_controller()->
RegisterBlobUrl(blob_url, blob_data);
- operation()->Write(url_request_context, file_, blob_url, 0);
+ operation()->Write(url_request_context, URLForPath(file_), blob_url, 0);
MessageLoop::current()->Run();
url_request_context->blob_storage_controller()->UnregisterBlobUrl(blob_url);
@@ -204,7 +213,8 @@
scoped_refptr<TestURLRequestContext> url_request_context(
new TestURLRequestContext());
- operation()->Write(url_request_context, file_, GURL("blob:invalid"), 0);
+ operation()->Write(url_request_context, URLForPath(file_),
+ GURL("blob:invalid"), 0);
MessageLoop::current()->Run();
EXPECT_EQ(0, bytes_written());
@@ -223,7 +233,7 @@
RegisterBlobUrl(blob_url, blob_data);
operation()->Write(url_request_context,
- FilePath(FILE_PATH_LITERAL("/nonexist")), blob_url, 0);
+ URLForRelativePath("nonexist"), blob_url, 0);
MessageLoop::current()->Run();
url_request_context->blob_storage_controller()->UnregisterBlobUrl(blob_url);
@@ -243,7 +253,7 @@
url_request_context->blob_storage_controller()->
RegisterBlobUrl(blob_url, blob_data);
- operation()->Write(url_request_context, dir_.path(), blob_url, 0);
+ operation()->Write(url_request_context, URLForPath(dir_.path()), blob_url, 0);
MessageLoop::current()->Run();
url_request_context->blob_storage_controller()->UnregisterBlobUrl(blob_url);
« no previous file with comments | « webkit/fileapi/file_system_operation_unittest.cc ('k') | webkit/fileapi/file_system_path_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698