More filesystem cleanup: convert URL-encoded-as-FilePath to actual URL, where

webkit/tools/test_shell/simple_file_system.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/tools/test_shell/simple_file_system.h"
 
 #include "base/file_path.h"
 #include "base/memory/scoped_callback_factory.h"
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
@@ skipping 77 matching lines @@
       entry.name = webkit_glue::FilePathStringToWebString(it->name);
       entry.isDirectory = it->is_directory;
       web_entries_vector.push_back(entry);
     }
     WebVector<WebKit::WebFileSystemEntry> web_entries =
         web_entries_vector;
     callbacks_->didReadDirectory(web_entries, has_more);
   }
 
   virtual void DidOpenFileSystem(
-      const std::string& name, const FilePath& path) {
+      const std::string& name, const GURL& root) {
     DCHECK(file_system_);
-    if (path.empty())
+    if (!root.is_valid())
       callbacks_->didFail(WebKit::WebFileErrorSecurity);
     else
       callbacks_->didOpenFileSystem(
-          UTF8ToUTF16(name), webkit_glue::FilePathToWebString(path));
+          WebString::fromUTF8(name), WebString::fromUTF8(root.spec()));
   }
 
   virtual void DidFail(base::PlatformFileError error_code) {
     DCHECK(file_system_);
     callbacks_->didFail(
         webkit_glue::PlatformFileErrorToWebFileError(error_code));
   }
 
   virtual void DidWrite(int64, bool) {
     NOTREACHED();
@@ skipping 46 matching lines @@
     return;
   }
 
   GURL origin_url(frame->securityOrigin().toString());
   GetNewOperation(callbacks)->OpenFileSystem(origin_url, type, create);
 }
 
 void SimpleFileSystem::move(
     const WebString& src_path,
     const WebString& dest_path, WebFileSystemCallbacks* callbacks) {
-  FilePath dest_filepath(webkit_glue::WebStringToFilePath(dest_path));
-  FilePath src_filepath(webkit_glue::WebStringToFilePath(src_path));
-
-  GetNewOperation(callbacks)->Move(src_filepath, dest_filepath);
+  GetNewOperation(callbacks)->Move(GURL(src_path), GURL(dest_path));
 }
 
 void SimpleFileSystem::copy(
     const WebString& src_path, const WebString& dest_path,
     WebFileSystemCallbacks* callbacks) {
-  FilePath dest_filepath(webkit_glue::WebStringToFilePath(dest_path));
-  FilePath src_filepath(webkit_glue::WebStringToFilePath(src_path));
-
-  GetNewOperation(callbacks)->Copy(src_filepath, dest_filepath);
+  GetNewOperation(callbacks)->Copy(GURL(src_path), GURL(dest_path));
 }
 
 void SimpleFileSystem::remove(
     const WebString& path, WebFileSystemCallbacks* callbacks) {
-  FilePath filepath(webkit_glue::WebStringToFilePath(path));
-
-  GetNewOperation(callbacks)->Remove(filepath, false /* recursive */);
+  GetNewOperation(callbacks)->Remove(GURL(path), false /* recursive */);
 }
 
 void SimpleFileSystem::removeRecursively(
     const WebString& path, WebFileSystemCallbacks* callbacks) {
-  FilePath filepath(webkit_glue::WebStringToFilePath(path));
-
-  GetNewOperation(callbacks)->Remove(filepath, true /* recursive */);
+  GetNewOperation(callbacks)->Remove(GURL(path), true /* recursive */);
 }
 
 void SimpleFileSystem::readMetadata(
     const WebString& path, WebFileSystemCallbacks* callbacks) {
-  FilePath filepath(webkit_glue::WebStringToFilePath(path));
-
-  GetNewOperation(callbacks)->GetMetadata(filepath);
+  GetNewOperation(callbacks)->GetMetadata(GURL(path));
 }
 
 void SimpleFileSystem::createFile(
     const WebString& path, bool exclusive, WebFileSystemCallbacks* callbacks) {
-  FilePath filepath(webkit_glue::WebStringToFilePath(path));
-
-  GetNewOperation(callbacks)->CreateFile(filepath, exclusive);
+  GetNewOperation(callbacks)->CreateFile(GURL(path), exclusive);
 }
 
 void SimpleFileSystem::createDirectory(
     const WebString& path, bool exclusive, WebFileSystemCallbacks* callbacks) {
-  FilePath filepath(webkit_glue::WebStringToFilePath(path));
-
-  GetNewOperation(callbacks)->CreateDirectory(filepath, exclusive, false);
+  GetNewOperation(callbacks)->CreateDirectory(GURL(path), exclusive, false);
 }
 
 void SimpleFileSystem::fileExists(
     const WebString& path, WebFileSystemCallbacks* callbacks) {
-  FilePath filepath(webkit_glue::WebStringToFilePath(path));
-
-  GetNewOperation(callbacks)->FileExists(filepath);
+  GetNewOperation(callbacks)->FileExists(GURL(path));
 }
 
 void SimpleFileSystem::directoryExists(
     const WebString& path, WebFileSystemCallbacks* callbacks) {
-  FilePath filepath(webkit_glue::WebStringToFilePath(path));
-
-  GetNewOperation(callbacks)->DirectoryExists(filepath);
+  GetNewOperation(callbacks)->DirectoryExists(GURL(path));
 }
 
 void SimpleFileSystem::readDirectory(
     const WebString& path, WebFileSystemCallbacks* callbacks) {
-  FilePath filepath(webkit_glue::WebStringToFilePath(path));
-
-  GetNewOperation(callbacks)->ReadDirectory(filepath);
+  GetNewOperation(callbacks)->ReadDirectory(GURL(path));
 }
 
 WebFileWriter* SimpleFileSystem::createFileWriter(
     const WebString& path, WebFileWriterClient* client) {
-  return new SimpleFileWriter(path, client, file_system_context_.get());
+  return new SimpleFileWriter(GURL(path), client, file_system_context_.get());
 }
 
 FileSystemOperation* SimpleFileSystem::GetNewOperation(
     WebFileSystemCallbacks* callbacks) {
   SimpleFileSystemCallbackDispatcher* dispatcher =
       new SimpleFileSystemCallbackDispatcher(AsWeakPtr(), callbacks);
   FileSystemOperation* operation = new FileSystemOperation(
       dispatcher, base::MessageLoopProxy::CreateForCurrentThread(),
       file_system_context_.get(), NULL);
   return operation;
 }