Source/web/WebDOMMessageEvent.cpp - Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebDOMMessageEvent.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix incorrect assumption Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebDOMMessageEvent.cpp

diff --git a/Source/web/WebDOMMessageEvent.cpp b/Source/web/WebDOMMessageEvent.cpp

index 0e76871d536bf89e9aab8c6b19cc3b07492f8c5c..f03bb3897aac026ac698e942bb33af518c650f28 100644

--- a/Source/web/WebDOMMessageEvent.cpp

+++ b/Source/web/WebDOMMessageEvent.cpp

@@ -48,8 +48,9 @@ void WebDOMMessageEvent::initMessageEvent(const WebString& type, bool canBubble,

ASSERT(m_private.get());

ASSERT(isMessageEvent());

LocalDOMWindow* window = 0;

+ // FIXME: Figure out if this is the right thing to do.

if (sourceFrame)

- window = toWebLocalFrameImpl(sourceFrame)->frame()->domWindow();

+ window = toWebLocalFrameImpl(sourceFrame)->frame()->localDOMWindow();

OwnPtrWillBeRawPtr<MessagePortArray> ports = nullptr;

if (sourceFrame)

ports = MessagePort::toMessagePortArray(window->document(), webChannels);