Source/modules/webdatabase/DOMWindowWebDatabase.cpp - Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/DOMWindowWebDatabase.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix incorrect assumption Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/speech/DOMWindowSpeechSynthesis.cpp ('K') | « Source/modules/webdatabase/DOMWindowWebDatabase.h ('k') | Source/web/WebDOMMessageEvent.cpp » ('j') | Source/web/WebLocalFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/DOMWindowWebDatabase.cpp

diff --git a/Source/modules/webdatabase/DOMWindowWebDatabase.cpp b/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

index 59cd30231c7df0280c43530ac3fdde181ae1617d..0524d863b30ee8b1fc358f89d6a7ae70f3e80c10 100644

--- a/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

+++ b/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

@@ -40,8 +40,9 @@

namespace blink {

-Database* DOMWindowWebDatabase::openDatabase(LocalDOMWindow& window, const String& name, const String& version, const String& displayName, unsigned long estimatedSize, DatabaseCallback* creationCallback, ExceptionState& exceptionState)

+Database* DOMWindowWebDatabase::openDatabase(DOMWindow& windowArg, const String& name, const String& version, const String& displayName, unsigned long estimatedSize, DatabaseCallback* creationCallback, ExceptionState& exceptionState)

haraken 2014/11/08 09:17:25 Ditto.

{

+ LocalDOMWindow& window = toLocalDOMWindow(windowArg);

if (!window.isCurrentlyDisplayedInFrame())

return nullptr;