Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2019)

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 683013002: Extract a DOMWindow interface from LocalDOMWindow and use it in the idl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix incorrect assumption Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebLocalFrameImpl.cpp
diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp
index b19b1a5a5160d3649668ffcadd2cdcd9c975dbb0..2263ec5fae6e8dea577a89d033c4b4f6936dd946 100644
--- a/Source/web/WebLocalFrameImpl.cpp
+++ b/Source/web/WebLocalFrameImpl.cpp
@@ -962,7 +962,7 @@ WebURLLoader* WebLocalFrameImpl::createAssociatedURLLoader(const WebURLLoaderOpt
unsigned WebLocalFrameImpl::unloadListenerCount() const
{
- return frame()->domWindow()->pendingUnloadEventListeners();
+ return frame()->localDOMWindow()->pendingUnloadEventListeners();
haraken 2014/11/08 09:17:25 I'd propose to rename frame() to localFrame() to r
}
void WebLocalFrameImpl::replaceSelection(const WebString& text)
@@ -1413,7 +1413,7 @@ void WebLocalFrameImpl::resetMatchCount()
void WebLocalFrameImpl::dispatchMessageEventWithOriginCheck(const WebSecurityOrigin& intendedTargetOrigin, const WebDOMEvent& event)
{
ASSERT(!event.isNull());
- frame()->domWindow()->dispatchMessageEventWithOriginCheck(intendedTargetOrigin.get(), event, nullptr);
+ frame()->localDOMWindow()->dispatchMessageEventWithOriginCheck(intendedTargetOrigin.get(), event, nullptr);
}
int WebLocalFrameImpl::findMatchMarkersVersion() const
@@ -1906,7 +1906,7 @@ void WebLocalFrameImpl::sendOrientationChangeEvent()
// Legacy window.orientation API
if (RuntimeEnabledFeatures::orientationEventEnabled() && frame()->domWindow())
- frame()->domWindow()->sendOrientationChangeEvent();
+ frame()->localDOMWindow()->sendOrientationChangeEvent();
}
v8::Handle<v8::Value> WebLocalFrameImpl::executeScriptAndReturnValueForTests(const WebScriptSource& source)

Powered by Google App Engine
This is Rietveld 408576698