Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 682583002: Make use of new faster Blink AX live region APIs. (Closed)

Created:
6 years, 1 month ago by dmazzoni
Modified:
6 years, 1 month ago
Reviewers:
aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@profiling
Project:
chromium
Visibility:
Public.

Description

Make use of new faster Blink AX live region APIs. This makes generating the accessibility tree for at least one page more than 25% faster, and it should help at least a bit on almost any page. BUG=427402 Committed: https://crrev.com/9cabe256d4cff48ffba428c872c750f6b9000ee3 Cr-Commit-Position: refs/heads/master@{#302236}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update expectations #

Patch Set 3 : Update Mac expectations too #

Patch Set 4 : Update Android expectations #

Messages

Total messages: 22 (8 generated)
dmazzoni
6 years, 1 month ago (2014-10-27 07:22:30 UTC) #2
aboxhall
https://codereview.chromium.org/682583002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc File content/renderer/accessibility/blink_ax_tree_source.cc (right): https://codereview.chromium.org/682583002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc#newcode377 content/renderer/accessibility/blink_ax_tree_source.cc:377: if (src.isInLiveRegion()) { I couldn't find this method - ...
6 years, 1 month ago (2014-10-27 16:37:37 UTC) #3
aboxhall
On 2014/10/27 16:37:37, aboxhall wrote: > https://codereview.chromium.org/682583002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc > File content/renderer/accessibility/blink_ax_tree_source.cc (right): > > https://codereview.chromium.org/682583002/diff/1/content/renderer/accessibility/blink_ax_tree_source.cc#newcode377 > ...
6 years, 1 month ago (2014-10-27 16:46:49 UTC) #4
dmazzoni
PTAL again now that you've reviewed the change this depends on?
6 years, 1 month ago (2014-10-27 19:25:55 UTC) #5
aboxhall
lgtm
6 years, 1 month ago (2014-10-27 19:36:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682583002/1
6 years, 1 month ago (2014-10-28 06:18:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/23637)
6 years, 1 month ago (2014-10-28 07:30:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682583002/20001
6 years, 1 month ago (2014-10-29 09:28:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/7445)
6 years, 1 month ago (2014-10-29 10:41:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682583002/40001
6 years, 1 month ago (2014-10-29 15:52:48 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/23289)
6 years, 1 month ago (2014-10-29 17:48:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682583002/60001
6 years, 1 month ago (2014-10-31 06:02:57 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-31 06:55:04 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 07:24:44 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9cabe256d4cff48ffba428c872c750f6b9000ee3
Cr-Commit-Position: refs/heads/master@{#302236}

Powered by Google App Engine
This is Rietveld 408576698