Add live region root to the cached properties of an AXObject.

Add live region root to the cached properties of an AXObject.

This adds the live region root to the set of properties of an
AXObject that are cached. The live region root is simply the
root object of the live region an object is contained in, if any.
Also exposes new "container" functions exposing the value of
live region properties of the live region root, for any given
node.

This will be followed by a Chromium change to use these new APIs.

BUG=427402
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184471

[dmazzoni, 2014-10-27 07:22:20]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[aboxhall, 2014-10-27 17:29:53]

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXObject.cpp:269: m_cachedLiveRegionRoot =
isLiveRegion() ? this : (parentObjectIfExists() ?
parentObjectIfExists()->liveRegionRoot() : 0);
I'd consider wrapping this onto a few lines to make the logic clearer.

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXObject.h (left):

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXObject.h:583: private:
Is this removal deliberate?

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXScrollView.cpp (right):

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXScrollView.cpp:160: return false;
Why did this change from true to false?

[dmazzoni, 2014-10-27 18:08:25]

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXObject.cpp:269: m_cachedLiveRegionRoot =
isLiveRegion() ? this : (parentObjectIfExists() ?
parentObjectIfExists()->liveRegionRoot() : 0);
On 2014/10/27 17:29:53, aboxhall wrote:
> I'd consider wrapping this onto a few lines to make the logic clearer.

Done.

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXObject.h (left):

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXObject.h:583: private:
On 2014/10/27 17:29:53, aboxhall wrote:
> Is this removal deliberate?

Yes, the changes to AXScrollView require these to be protected and not private.

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXScrollView.cpp (right):

https://codereview.chromium.org/659563006/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXScrollView.cpp:160: return false;
On 2014/10/27 17:29:53, aboxhall wrote:
> Why did this change from true to false?

Good catch - should be true. Thanks.

[aboxhall, 2014-10-27 18:20:33]

lgtm

[dmazzoni, 2014-10-27 18:59:24]

dmazzoni@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dmazzoni, 2014-10-27 18:59:25]

+dglazkov for OWNERS review of public/web

[dglazkov, 2014-10-27 19:04:54]

lgtm

[dmazzoni, 2014-10-27 19:09:01]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-10-27 19:10:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/659563006/20001

[commit-bot: I haz the power, 2014-10-27 20:22:33]

Committed patchset #2 (id:20001) as 184471