Issue 682363002: Remove more scrolling methods from FrameView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682363002: Remove more scrolling methods from FrameView. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove more scrolling methods from FrameView. No change in behavior. Just deleting dead code. Also removes ScrollAnimatorNone since it's unused. We'll need to bring some of this back, but we'll do that when we get rid of composited scrolling. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b615fd467f3d48b60763f3c0f7f9da02db21a97a

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -863 lines)			Patch
M	sky/engine/core/frame/EventHandlerRegistry.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	3 chunks	+0 lines, -60 lines	0 comments	Download
M	sky/engine/core/frame/Settings.in	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/page/scrolling/ScrollingCoordinator.h	View	3 chunks	+0 lines, -10 lines	0 comments	Download
M	sky/engine/core/page/scrolling/ScrollingCoordinator.cpp	View	4 chunks	+3 lines, -77 lines	0 comments	Download
M	sky/engine/platform/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/platform/scroll/ScrollAnimator.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
D	sky/engine/platform/scroll/ScrollAnimatorNone.h	View	1 chunk	+0 lines, -152 lines	0 comments	Download
D	sky/engine/platform/scroll/ScrollAnimatorNone.cpp	View	1 chunk	+0 lines, -525 lines	0 comments	Download
M	sky/engine/platform/scroll/ScrollableArea.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/public/web/WebSettings.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebSettingsImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebSettingsImpl.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (1 generated)

ojan

6 years, 1 month ago (2014-10-29 00:38:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b615fd467f3d48b60763f3c0f7f9da02db21a97a (presubmit successful).