Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: sky/engine/core/frame/FrameView.cpp

Issue 682363002: Remove more scrolling methods from FrameView. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/frame/Settings.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameView.cpp
diff --git a/sky/engine/core/frame/FrameView.cpp b/sky/engine/core/frame/FrameView.cpp
index b6ae44b75a441b284c28938df36aab85a9728ae0..1eabef73eaf31cf5635ea60b307297a51eb2a23b 100644
--- a/sky/engine/core/frame/FrameView.cpp
+++ b/sky/engine/core/frame/FrameView.cpp
@@ -231,48 +231,6 @@ void FrameView::recalcOverflowAfterStyleChange()
renderView->recalcOverflowAfterStyleChange();
}
-bool FrameView::usesCompositedScrolling() const
-{
- RenderView* renderView = this->renderView();
- if (!renderView)
- return false;
- if (m_frame->settings() && m_frame->settings()->preferCompositingToLCDTextEnabled())
- return renderView->compositor()->inCompositingMode();
- return false;
-}
-
-GraphicsLayer* FrameView::layerForScrolling() const
-{
- RenderView* renderView = this->renderView();
- if (!renderView)
- return 0;
- return renderView->compositor()->scrollLayer();
-}
-
-GraphicsLayer* FrameView::layerForHorizontalScrollbar() const
-{
- RenderView* renderView = this->renderView();
- if (!renderView)
- return 0;
- return renderView->compositor()->layerForHorizontalScrollbar();
-}
-
-GraphicsLayer* FrameView::layerForVerticalScrollbar() const
-{
- RenderView* renderView = this->renderView();
- if (!renderView)
- return 0;
- return renderView->compositor()->layerForVerticalScrollbar();
-}
-
-GraphicsLayer* FrameView::layerForScrollCorner() const
-{
- RenderView* renderView = this->renderView();
- if (!renderView)
- return 0;
- return renderView->compositor()->layerForScrollCorner();
-}
-
IntRect FrameView::contentsToScreen(const IntRect& rect) const
{
HostWindow* window = hostWindow();
@@ -926,14 +884,6 @@ bool FrameView::isActive() const
return page && page->focusController().isActive();
}
-void FrameView::getTickmarks(Vector<IntRect>& tickmarks) const
-{
- if (!m_tickmarks.isEmpty())
- tickmarks = m_tickmarks;
- else
- tickmarks = frame().document()->markers().renderedRectsForMarkers(DocumentMarker::TextMatch);
-}
-
void FrameView::setVisibleContentScaleFactor(float visibleContentScaleFactor)
{
if (m_visibleContentScaleFactor == visibleContentScaleFactor)
@@ -958,16 +908,6 @@ float FrameView::inputEventsScaleFactor() const
return pageScale * m_inputEventsScaleFactorForEmulation;
}
-IntRect FrameView::scrollableAreaBoundingBox() const
-{
- return frameRect();
-}
-
-bool FrameView::scrollAnimatorEnabled() const
-{
- return m_frame->settings() && m_frame->settings()->scrollAnimatorEnabled();
-}
-
Color FrameView::documentBackgroundColor() const
{
// <https://bugs.webkit.org/show_bug.cgi?id=59540> We blend the background color of
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/frame/Settings.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698