Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: sky/engine/core/page/scrolling/ScrollingCoordinator.h

Issue 682363002: Remove more scrolling methods from FrameView. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/Settings.in ('k') | sky/engine/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/page/scrolling/ScrollingCoordinator.h
diff --git a/sky/engine/core/page/scrolling/ScrollingCoordinator.h b/sky/engine/core/page/scrolling/ScrollingCoordinator.h
index f221825d3b860b437ffc45088d56d4b291c86cd9..c9ed1d0376331d59dfa481623ee55072399453ab 100644
--- a/sky/engine/core/page/scrolling/ScrollingCoordinator.h
+++ b/sky/engine/core/page/scrolling/ScrollingCoordinator.h
@@ -59,9 +59,6 @@ public:
void updateAfterCompositingChangeIfNeeded();
- void updateHaveWheelEventHandlers();
- void updateHaveScrollEventHandlers();
-
#if OS(MACOSX)
// Dispatched by the scrolling tree during handleWheelEvent. This is required as long as scrollbars are painted on the main thread.
void handleWheelEventPhase(PlatformWheelEventPhase);
@@ -95,14 +92,9 @@ protected:
Page* m_page;
// Dirty flags used to idenfity what really needs to be computed after compositing is updated.
- bool m_scrollGestureRegionIsDirty;
bool m_touchEventTargetRectsAreDirty;
- bool m_shouldScrollOnMainThreadDirty;
private:
- bool shouldUpdateAfterCompositingChange() const { return m_scrollGestureRegionIsDirty || m_touchEventTargetRectsAreDirty || frameViewIsDirty(); }
-
- void setShouldHandleScrollGestureOnMainThreadRegion(const Region&);
void setTouchEventTargetRects(LayerHitTestRects&);
void computeTouchEventTargetRects(LayerHitTestRects&);
@@ -110,8 +102,6 @@ private:
blink::WebScrollbarLayer* getWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation);
void removeWebScrollbarLayer(ScrollableArea*, ScrollbarOrientation);
- bool frameViewIsDirty() const;
-
typedef HashMap<ScrollableArea*, OwnPtr<blink::WebScrollbarLayer> > ScrollbarMap;
ScrollbarMap m_horizontalScrollbars;
ScrollbarMap m_verticalScrollbars;
« no previous file with comments | « sky/engine/core/frame/Settings.in ('k') | sky/engine/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698