Issue 682263003: Remove RenderWidget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682263003: Remove RenderWidget. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove RenderWidget. This is part of the old iframe and plugin system, we don't need it. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/33f272a3a5fecbdcc700c52bf07907fe1ef3ea04

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -508 lines)			Patch
M	sky/engine/core/core.gni	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	4 chunks	+4 lines, -33 lines	0 comments	Download
M	sky/engine/core/editing/FrameSelection.cpp	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.h	View	7 chunks	+0 lines, -16 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	6 chunks	+0 lines, -44 lines	0 comments	Download
M	sky/engine/core/page/EventHandler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/page/EventHandler.cpp	View	3 chunks	+2 lines, -22 lines	0 comments	Download
M	sky/engine/core/rendering/HitTestResult.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/PaintInfo.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayerScrollableArea.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/RenderTreeAsText.cpp	View	2 chunks	+0 lines, -15 lines	0 comments	Download
D	sky/engine/core/rendering/RenderWidget.h	View	1 chunk	+0 lines, -72 lines	0 comments	Download
D	sky/engine/core/rendering/RenderWidget.cpp	View	1 chunk	+0 lines, -284 lines	0 comments	Download
M	sky/engine/web/ChromeClientImpl.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebNode.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

esprehn

6 years, 1 month ago (2014-10-28 22:10:36 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
33f272a3a5fecbdcc700c52bf07907fe1ef3ea04.

Expand Messages | Collapse Messages