Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: sky/engine/core/frame/FrameView.h

Issue 682263003: Remove RenderWidget. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/editing/FrameSelection.cpp ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameView.h
diff --git a/sky/engine/core/frame/FrameView.h b/sky/engine/core/frame/FrameView.h
index 5bff1a44f301657d6536b4c4f4096350c3e876b2..6cef375c85304d992cdcff57142aee25fe00501c 100644
--- a/sky/engine/core/frame/FrameView.h
+++ b/sky/engine/core/frame/FrameView.h
@@ -53,7 +53,6 @@ class RenderBox;
class RenderObject;
class RenderStyle;
class RenderView;
-class RenderWidget;
typedef unsigned long long DOMTimeStamp;
@@ -95,8 +94,6 @@ public:
bool needsLayout() const;
void setNeedsLayout();
- void setNeedsUpdateWidgetPositions() { m_needsUpdateWidgetPositions = true; }
-
// Methods for getting/setting the size Blink should use to layout the contents.
IntSize layoutSize(IncludeScrollbarsInRect = ExcludeScrollbars) const;
void setLayoutSize(const IntSize&);
@@ -148,10 +145,6 @@ public:
bool wasScrolledByUser() const;
void setWasScrolledByUser(bool);
- void addWidget(RenderWidget*);
- void removeWidget(RenderWidget*);
- void updateWidgetPositions();
-
void paintContents(GraphicsContext*, const IntRect& damageRect);
void setPaintBehavior(PaintBehavior);
PaintBehavior paintBehavior() const;
@@ -288,8 +281,6 @@ private:
virtual void frameRectsChanged() override;
virtual bool isFrameView() const override { return true; }
- friend class RenderWidget;
-
bool contentsInCompositedLayer() const;
void applyOverflowToViewportAndSetRenderer(RenderObject*, ScrollbarMode& hMode, ScrollbarMode& vMode);
@@ -319,8 +310,6 @@ private:
virtual IntPoint convertToContainingView(const IntPoint&) const override;
virtual IntPoint convertFromContainingView(const IntPoint&) const override;
- void updateWidgetPositionsIfNeeded();
-
bool wasViewportResized();
void sendResizeEventIfNeeded();
@@ -341,9 +330,6 @@ private:
LayoutSize m_size;
- // FIXME: These are just "children" of the FrameView and should be RefPtr<Widget> instead.
- HashSet<RefPtr<RenderWidget> > m_widgets;
-
RefPtr<LocalFrame> m_frame;
HashSet<RefPtr<Widget> > m_children;
@@ -404,8 +390,6 @@ private:
Timer<FrameView> m_didScrollTimer;
Vector<IntRect> m_tickmarks;
-
- bool m_needsUpdateWidgetPositions;
};
DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFrameView());
« no previous file with comments | « sky/engine/core/editing/FrameSelection.cpp ('k') | sky/engine/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698