Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 682003003: Simplify WebServiceWorker{Registration}Proxy interfaces. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
6 years, 1 month ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Simplify WebServiceWorker{Registration}Proxy interfaces. Turn WebServiceWorkerRegistrationProxy and WebServiceWorkerProxy into pure abstract interfaces, letting the embedder call the "proxy" interfaces on the ServiceWorkerRegistration and ServiceWorker Blink objects, respectively. That is, no longer keep private (and bare) pointers on these platform proxy objects; unnecessary and runs up against overall platform layering constraints. Like before, the ownership of these proxy objects resides with Blink. R=nhiroki,haraken,mkwst BUG=410257 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184587

Patch Set 1 #

Patch Set 2 : Remove Impl wrapper layer; extend to also cover WebServiceWorkerProxy #

Total comments: 1

Patch Set 3 : Remove incorrect FIXME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -88 lines) Patch
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 2 chunks +4 lines, -8 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
D Source/platform/exported/WebServiceWorkerProxy.cpp View 1 1 chunk +0 lines, -22 lines 0 comments Download
D Source/platform/exported/WebServiceWorkerRegistrationProxy.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M public/platform/WebServiceWorkerProxy.h View 1 2 2 chunks +1 line, -13 lines 0 comments Download
M public/platform/WebServiceWorkerRegistrationProxy.h View 1 3 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
sof
Please take a look. Perhaps I'm overlooking some aspect wrt keeping these m_private bare pointers, ...
6 years, 1 month ago (2014-10-28 13:17:06 UTC) #2
nhiroki
LGTM, thank you for working on this!
6 years, 1 month ago (2014-10-29 03:40:57 UTC) #3
haraken
LGTM
6 years, 1 month ago (2014-10-29 04:19:55 UTC) #4
sof
Thanks for the reviews. tkent, jochen: could you look at the public/platform/ changes when you ...
6 years, 1 month ago (2014-10-29 06:49:38 UTC) #6
Mike West
public/platform LGTM.
6 years, 1 month ago (2014-10-29 07:59:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682003003/40001
6 years, 1 month ago (2014-10-29 08:04:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/34130)
6 years, 1 month ago (2014-10-29 11:19:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/682003003/40001
6 years, 1 month ago (2014-10-29 11:33:29 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 13:20:51 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184587

Powered by Google App Engine
This is Rietveld 408576698