Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: public/platform/WebServiceWorkerProxy.h

Issue 682003003: Simplify WebServiceWorker{Registration}Proxy interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove incorrect FIXME Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebServiceWorkerProxy.h
diff --git a/public/platform/WebServiceWorkerProxy.h b/public/platform/WebServiceWorkerProxy.h
index 4a213794b86808103c24e48bd4491808c2bc37a8..4a82dd75e32e0d538310e84fa9f126afd307a519 100644
--- a/public/platform/WebServiceWorkerProxy.h
+++ b/public/platform/WebServiceWorkerProxy.h
@@ -5,19 +5,12 @@
#ifndef WebServiceWorkerProxy_h
#define WebServiceWorkerProxy_h
-#include "WebCommon.h"
-
namespace blink {
-class ServiceWorker;
-
// A proxy interface, passed via WebServiceWorker.setProxy() from blink to
// the embedder, to talk to the ServiceWorker object from embedder.
class WebServiceWorkerProxy {
public:
- WebServiceWorkerProxy() : m_private(0) { }
- virtual ~WebServiceWorkerProxy() { }
-
// Returns true if the proxy is ready to be notified of service worker state
// changes. It may not be if it's waiting for the registration promise to
// resolve, while the browser side has registered and is proceeding to
@@ -28,13 +21,8 @@ public:
// should be accessible via WebServiceWorker.state().
virtual void dispatchStateChangeEvent() = 0;
-#if INSIDE_BLINK
- BLINK_PLATFORM_EXPORT WebServiceWorkerProxy(ServiceWorker*);
- BLINK_PLATFORM_EXPORT ServiceWorker* unwrap() const;
-#endif
-
protected:
- ServiceWorker* m_private;
+ virtual ~WebServiceWorkerProxy() { }
};
} // namespace blink
« no previous file with comments | « Source/platform/exported/WebServiceWorkerRegistrationProxy.cpp ('k') | public/platform/WebServiceWorkerRegistrationProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698