Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: public/platform/WebServiceWorkerRegistrationProxy.h

Issue 682003003: Simplify WebServiceWorker{Registration}Proxy interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove incorrect FIXME Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/platform/WebServiceWorkerProxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebServiceWorkerRegistrationProxy.h
diff --git a/public/platform/WebServiceWorkerRegistrationProxy.h b/public/platform/WebServiceWorkerRegistrationProxy.h
index b6d6d37cbffe0180427b20963c926b837bfdc353..e6a7a81627e6a00c19669bd7f68c6159482a5724 100644
--- a/public/platform/WebServiceWorkerRegistrationProxy.h
+++ b/public/platform/WebServiceWorkerRegistrationProxy.h
@@ -5,14 +5,8 @@
#ifndef WebServiceWorkerRegistrationProxy_h
#define WebServiceWorkerRegistrationProxy_h
-#if INSIDE_BLINK
-#include "platform/heap/Handle.h"
-#endif
-#include "public/platform/WebCommon.h"
-
namespace blink {
-class ServiceWorkerRegistration;
class WebServiceWorker;
// A proxy interface, passed via WebServiceWorkerRegistration.setProxy() from
@@ -20,9 +14,6 @@ class WebServiceWorker;
// embedder.
class WebServiceWorkerRegistrationProxy {
public:
- WebServiceWorkerRegistrationProxy() : m_private(0) { }
- virtual ~WebServiceWorkerRegistrationProxy() { }
-
// Notifies that the registration entered the installation process.
// The installing worker should be accessible via
// WebServiceWorkerRegistration.installing.
@@ -32,18 +23,8 @@ public:
virtual void setWaiting(WebServiceWorker*) = 0;
virtual void setActive(WebServiceWorker*) = 0;
-#if INSIDE_BLINK
- BLINK_PLATFORM_EXPORT WebServiceWorkerRegistrationProxy(ServiceWorkerRegistration*);
- BLINK_PLATFORM_EXPORT operator ServiceWorkerRegistration*() const;
-#endif
-
protected:
-#if INSIDE_BLINK
- // This is a back pointer to |this| object.
- // The ServiceWorkerRegistration inherits from this WebServiceWorkerRegistrationProxy.
- GC_PLUGIN_IGNORE("crbug.com/410257")
-#endif
- ServiceWorkerRegistration* m_private;
+ virtual ~WebServiceWorkerRegistrationProxy() { }
};
} // namespace blink
« no previous file with comments | « public/platform/WebServiceWorkerProxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698