Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(102)

Issue 68173026: Allowing post area names to be >32767. (Closed)

Created:
6 years, 9 months ago by bradn
Modified:
6 years, 8 months ago
Reviewers:
Kunihiko Sakamoto, Yusuke Sato, unifoundry
CC:
chromium-reviews, unifoundry_unifoundry.com
Base URL:
https://chromium.googlesource.com/external/ots.git@master
Visibility:
Public.

Description

Allowing post area names to be >32767. Some fonts that cover all of unicode require post name entries greater than 32767. While the standard strictly requires this limit. Common implementations support it (it was an artifact of 16-bit windows). Permitting this variance from the specification. BUG=None TEST=unifont.ttf passes validation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M src/post.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M test/BLACKLIST.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bradn
Hi Yusuke, I happened to run into Paul Hardy (maintainer of unifont) this weekend. He ...
6 years, 9 months ago (2013-11-16 22:56:29 UTC) #1
bradn
6 years, 9 months ago (2013-11-16 23:14:17 UTC) #2
Yusuke Sato
Thanks for the patch, Brad. LG, but I'd defer to ksakamoto@ who is a current ...
6 years, 8 months ago (2013-11-18 01:21:08 UTC) #3
unifoundry_gmail.com
On Sun, Nov 17, 2013 at 5:21 PM, <yusukes@chromium.org> wrote: > Thanks for the patch, ...
6 years, 8 months ago (2013-11-18 05:01:53 UTC) #4
Kunihiko Sakamoto
LGTM Thank you for the patch. The change looks good. I will land this after ...
6 years, 8 months ago (2013-11-19 06:23:27 UTC) #5
Kunihiko Sakamoto
On 2013/11/19 06:23:27, ksakamoto wrote: > LGTM > > Thank you for the patch. > ...
6 years, 8 months ago (2013-11-19 07:22:52 UTC) #6
unifoundry_gmail.com
6 years, 8 months ago (2013-11-19 13:18:24 UTC) #7
On Mon, Nov 18, 2013 at 11:22 PM, <ksakamoto@chromium.org> wrote:
>
>
> Landed in https://code.google.com/p/ots/source/detail?r=106


Thank you!

https://codereview.chromium.org/68173026/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698