Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: src/post.cc

Issue 68173026: Allowing post area names to be >32767. (Closed) Base URL: https://chromium.googlesource.com/external/ots.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/BLACKLIST.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/post.cc
diff --git a/src/post.cc b/src/post.cc
index 74ba453058679aee45725f8ef133d152cea84ff2..f4a0b0def778ab17ffe9be46d608a747b5f33458 100644
--- a/src/post.cc
+++ b/src/post.cc
@@ -76,10 +76,9 @@ bool ots_post_parse(OpenTypeFile *file, const uint8_t *data, size_t length) {
if (!table.ReadU16(&post->glyph_name_index[i])) {
return OTS_FAILURE();
}
- if (post->glyph_name_index[i] >= 32768) {
- // Note: droid_arialuni.ttf fails this test.
- return OTS_FAILURE(); // reserved area.
- }
+ // Note: A strict interpretation of the specification requires name indexes
+ // are less than 32768. This, however, excludes fonts like unifont.ttf
+ // which cover all of unicode.
}
// Now we have an array of Pascal strings. We have to check that they are all
« no previous file with comments | « no previous file | test/BLACKLIST.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698