Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 681643003: Fix bounds computation of all 0-input filters. (Closed)

Created:
6 years, 1 month ago by Stephen White
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix bounds computation of all 0-input filters. The SkRectShaderImageFilter had the same bug as previously fixed for SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste the implementation, this change makes all filters with 0 inputs return their source bounds, instead of returning false. BUG=427251 Committed: https://skia.googlesource.com/skia/+/8f3937d9fcb28018ec14db6697d41b645716d589

Patch Set 1 #

Patch Set 2 : Add test suppression #

Patch Set 3 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M include/effects/SkBitmapSource.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkBitmapSource.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/ImageFilterTest.cpp View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Stephen White
PTAL. Thanks!
6 years, 1 month ago (2014-10-27 03:13:16 UTC) #2
Stephen White
bsalomon@: PTAL. Thanks!
6 years, 1 month ago (2014-10-27 19:35:00 UTC) #4
bsalomon
lgtm
6 years, 1 month ago (2014-10-27 20:28:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681643003/20001
6 years, 1 month ago (2014-10-27 20:29:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ba036cc82b5a543a13cafd11a19ba0e3087fca38
6 years, 1 month ago (2014-10-27 20:38:17 UTC) #8
hcm
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/681153002/ by hcm@google.com. ...
6 years, 1 month ago (2014-10-28 03:16:15 UTC) #9
hcm
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/678273002/ by hcm@google.com. ...
6 years, 1 month ago (2014-10-28 03:54:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681643003/40001
6 years, 1 month ago (2014-10-29 16:15:51 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 19:36:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 8f3937d9fcb28018ec14db6697d41b645716d589

Powered by Google App Engine
This is Rietveld 408576698