Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 681153002: Revert of Fix bounds computation of all 0-input filters. (Closed)

Created:
6 years, 1 month ago by hcm
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, Stephen White
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Fix bounds computation of all 0-input filters. (patchset #2 id:20001 of https://codereview.chromium.org/681643003/) Reason for revert: Failures on image filter tests in Skia and Blink Original issue's description: > Fix bounds computation of all 0-input filters. > > The SkRectShaderImageFilter had the same bug as previously fixed for > SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste > the implementation, this change makes all filters with 0 inputs return > their source bounds, instead of returning false. > > BUG=427251 > > Committed: https://skia.googlesource.com/skia/+/ba036cc82b5a543a13cafd11a19ba0e3087fca38 TBR=bsalomon@google.com,senorblanco@chromium.org NOTREECHECKS=true NOTRY=true BUG=427251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M include/effects/SkBitmapSource.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkBitmapSource.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/ImageFilterTest.cpp View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hcm
Created Revert of Fix bounds computation of all 0-input filters.
6 years, 1 month ago (2014-10-28 03:16:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681153002/1
6 years, 1 month ago (2014-10-28 03:17:22 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 03:17:31 UTC) #4
Failed to apply patch for expectations/gm/ignored-tests.txt:
While running git apply --index -3 -p1;
  error: patch failed: expectations/gm/ignored-tests.txt:36
  Falling back to three-way merge...
  Applied patch to 'expectations/gm/ignored-tests.txt' with conflicts.
  U expectations/gm/ignored-tests.txt

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
63d6a8490d6fbef13d9f4308acd7c6a05c655e25..1499accc4aeaadf88e99a0172e012bca5d559e4c
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -36,10 +36,6 @@
 # robertphillips - skia:2995
 blurrects
 
-# senorblanco https://codereview.chromium.org/681643003/
-# minor pixel diffs from bounds change
-testimagefilters
-
 # sugoi https://codereview.chromium.org/646213004/
 # New shadow only option in SkDropShadowImageFilter
 dropshadowimagefilter

Powered by Google App Engine
This is Rietveld 408576698