Issue 678273002: Revert of Fix bounds computation of all 0-input filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 678273002: Revert of Fix bounds computation of all 0-input filters. (Closed)

Created:
6 years, 1 month ago by hcm

Modified:
6 years, 1 month ago

Reviewers:
bsalomon, Stephen White

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Fix bounds computation of all 0-input filters. (patchset #2 id:20001 of https://codereview.chromium.org/681643003/) Reason for revert: try again Original issue's description: > Fix bounds computation of all 0-input filters. > > The SkRectShaderImageFilter had the same bug as previously fixed for > SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste > the implementation, this change makes all filters with 0 inputs return > their source bounds, instead of returning false. > > BUG=427251 > > Committed: https://skia.googlesource.com/skia/+/ba036cc82b5a543a13cafd11a19ba0e3087fca38 TBR=bsalomon@google.com,senorblanco@chromium.org NOTREECHECKS=true NOTRY=true BUG=427251 Committed: https://skia.googlesource.com/skia/+/d0f1969100a0c00f41166f2fe616de56d44f4a59

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -12 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	include/effects/SkBitmapSource.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/effects/SkPictureImageFilter.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkImageFilter.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/effects/SkBitmapSource.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/effects/SkPictureImageFilter.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/ImageFilterTest.cpp	View	3 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

hcm

Created Revert of Fix bounds computation of all 0-input filters.

6 years, 1 month ago (2014-10-28 03:54:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678273002/1

6 years, 1 month ago (2014-10-28 03:54:52 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-28 03:55:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as d0f1969100a0c00f41166f2fe616de56d44f4a59