[Arguments] Mark functions with duplicated parameters.

[Arguments] Mark functions with duplicated parameters.

Add a bit to the scope, set when a duplicated parameter is detected by the
parser.  Propagate it to the shared function info.

Committed: http://code.google.com/p/v8/source/detail?r=7538

[Martin Maly, 2011-04-07 09:53:24]

We should make sure this change works well with lazy compilation. When we do
full parse we create shared function info out with all the necessary flags in
hand. If we set function up for lazy compilation we have incomplete shared
function info and may need to fill in the necessary flags after we do the full
parse during lazy compilation.

Other than that concern, LGTM.

[Kevin Millikin (Chromium), 2011-04-07 10:46:52]

Moved the bit to the function literal (it's per function, not per scope).

[Martin Maly, 2011-04-07 11:00:49]

LGTM.

http://codereview.chromium.org/6815006/diff/2002/src/scopes.h
File src/scopes.h (right):

http://codereview.chromium.org/6815006/diff/2002/src/scopes.h#newcode362
src/scopes.h:362: bool has_duplicate_parameters_;
Is this still needed?

http://codereview.chromium.org/6815006/diff/2002/src/scopes.h#newcode436
src/scopes.h:436: has_duplicate_parameters_ = false;
ditto.

[Kevin Millikin (Chromium), 2011-04-07 11:02:00]

http://codereview.chromium.org/6815006/diff/2002/src/scopes.h
File src/scopes.h (right):

http://codereview.chromium.org/6815006/diff/2002/src/scopes.h#newcode362
src/scopes.h:362: bool has_duplicate_parameters_;
On 2011/04/07 11:00:49, Martin Maly wrote:
> Is this still needed?

Good catch, removed.