Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: src/scopes.h

Issue 6815006: [Arguments] Mark functions with duplicated parameters. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/arguments
Patch Set: Moved bit from scope to function literal. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/parser.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 Variable* arguments_; 352 Variable* arguments_;
353 353
354 // Illegal redeclaration. 354 // Illegal redeclaration.
355 Expression* illegal_redecl_; 355 Expression* illegal_redecl_;
356 356
357 // Scope-specific information. 357 // Scope-specific information.
358 bool scope_inside_with_; // this scope is inside a 'with' of some outer scope 358 bool scope_inside_with_; // this scope is inside a 'with' of some outer scope
359 bool scope_contains_with_; // this scope contains a 'with' statement 359 bool scope_contains_with_; // this scope contains a 'with' statement
360 bool scope_calls_eval_; // this scope contains an 'eval' call 360 bool scope_calls_eval_; // this scope contains an 'eval' call
361 bool strict_mode_; // this scope is a strict mode scope 361 bool strict_mode_; // this scope is a strict mode scope
362 bool has_duplicate_parameters_;
Martin Maly 2011/04/07 11:00:49 Is this still needed?
Kevin Millikin (Chromium) 2011/04/07 11:02:00 Good catch, removed.
362 363
363 // Computed via PropagateScopeInfo. 364 // Computed via PropagateScopeInfo.
364 bool outer_scope_calls_eval_; 365 bool outer_scope_calls_eval_;
365 bool inner_scope_calls_eval_; 366 bool inner_scope_calls_eval_;
366 bool outer_scope_is_eval_scope_; 367 bool outer_scope_is_eval_scope_;
367 bool force_eager_compilation_; 368 bool force_eager_compilation_;
368 369
369 // Computed via AllocateVariables; function scopes only. 370 // Computed via AllocateVariables; function scopes only.
370 int num_stack_slots_; 371 int num_stack_slots_;
371 int num_heap_slots_; 372 int num_heap_slots_;
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 dynamics_ = NULL; 426 dynamics_ = NULL;
426 receiver_ = NULL; 427 receiver_ = NULL;
427 function_ = NULL; 428 function_ = NULL;
428 arguments_ = NULL; 429 arguments_ = NULL;
429 illegal_redecl_ = NULL; 430 illegal_redecl_ = NULL;
430 scope_inside_with_ = false; 431 scope_inside_with_ = false;
431 scope_contains_with_ = false; 432 scope_contains_with_ = false;
432 scope_calls_eval_ = false; 433 scope_calls_eval_ = false;
433 // Inherit the strict mode from the parent scope. 434 // Inherit the strict mode from the parent scope.
434 strict_mode_ = (outer_scope != NULL) && outer_scope->strict_mode_; 435 strict_mode_ = (outer_scope != NULL) && outer_scope->strict_mode_;
436 has_duplicate_parameters_ = false;
Martin Maly 2011/04/07 11:00:49 ditto.
435 outer_scope_calls_eval_ = false; 437 outer_scope_calls_eval_ = false;
436 inner_scope_calls_eval_ = false; 438 inner_scope_calls_eval_ = false;
437 outer_scope_is_eval_scope_ = false; 439 outer_scope_is_eval_scope_ = false;
438 force_eager_compilation_ = false; 440 force_eager_compilation_ = false;
439 num_stack_slots_ = 0; 441 num_stack_slots_ = 0;
440 num_heap_slots_ = 0; 442 num_heap_slots_ = 0;
441 scope_info_ = scope_info; 443 scope_info_ = scope_info;
442 } 444 }
443 }; 445 };
444 446
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 int nesting_level_; 493 int nesting_level_;
492 // Nesting level of outermost scope that is contained in a with statement, 494 // Nesting level of outermost scope that is contained in a with statement,
493 // or kNotInsideWith if there are no with's around the current scope. 495 // or kNotInsideWith if there are no with's around the current scope.
494 int inside_with_level_; 496 int inside_with_level_;
495 }; 497 };
496 498
497 499
498 } } // namespace v8::internal 500 } } // namespace v8::internal
499 501
500 #endif // V8_SCOPES_H_ 502 #endif // V8_SCOPES_H_
OLDNEW
« no previous file with comments | « src/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698