Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 681483004: [ServiceWorker] Introduce the directory restriction of ServiceWorker scope [3/3 blink] (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@UpdateTests
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Introduce the directory restriction of ServiceWorker scope [3/3 blink] This restriction doesn't allow registration of the ServiceWorker scope outside the script directory. As per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468 [1/3 blink] https://codereview.chromium.org/674133004/ Update LayoutTests to be subject to the directory restrictions. [2/3 chromium] https://codereview.chromium.org/677003002/ Introduce this restriction in Chromium side. [3/3 blink] This patch Introduce this restriction in Blink side and update LayoutTest. BUG=423983

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-default.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
A LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-default.html View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration.html View 1 chunk +31 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
horo
falken@ Could you please review this? https://codereview.chromium.org/672383003/ was reverted because of the chromium side test ...
6 years, 1 month ago (2014-10-25 01:39:16 UTC) #2
horo
6 years, 1 month ago (2014-10-26 04:00:13 UTC) #3
I'll close this cl.
I changed the way to re-introduce the scope restriction.

Powered by Google App Engine
This is Rietveld 408576698