Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 674133004: [ServiceWorker] Introduce the directory restriction of ServiceWorker scope [1/3 blink] (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Introduce the directory restriction of ServiceWorker scope [1/3 blink] This restriction doesn't allow registration of the ServiceWorker scope outside the script directory. As per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468 [1/3 blink] This patch Update LayoutTests to be subject to the directory restrictions. [2/3 chromium] https://codereview.chromium.org/677003002/ Introduce this restriction in Chromium side. [3/3 blink] https://codereview.chromium.org/681483004/ Introduce this restriction in Blink side and update LayoutTest. BUG=423983

Patch Set 1 : Same as https://codereview.chromium.org/672383003/ #

Patch Set 2 : Revert the changes in cpp and some tests in registration.html #

Patch Set 3 : remove LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-default.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -62 lines) Patch
M LayoutTests/http/tests/geofencing/apis_not_implemented.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-absolute-url.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-default.html View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-relative-path.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/force-refresh-registration.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/registration-stress.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/service-worker-gc.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/extendable-event-waituntil.html View 6 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/getregistration.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/interfaces.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/multiple-register.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html View 5 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration.html View 1 3 chunks +14 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-end-to-end.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-events.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-on-insecure-origin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-service-worker-attributes.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/test-helpers.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/state.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/uncontrolled-page.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-controller.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-then-register.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
horo
falken@ Could you please review this? https://codereview.chromium.org/672383003/ was reverted because of the chromium side test ...
6 years, 1 month ago (2014-10-25 01:39:43 UTC) #2
horo
6 years, 1 month ago (2014-10-26 03:59:50 UTC) #3
I'll close this cl.
I changed the way to re-introduce the scope restriction.

Powered by Google App Engine
This is Rietveld 408576698