Issue 681113004: Remove Heap.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 681113004: Remove Heap.h (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove Heap.h Had to move a couple macros into Handle.h (which we won't be able to remove for a while yet), but otherwise Heap is dead. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0796329e3a2290575d84575248289f1ea7954e84

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -1612 lines)			Patch
M	sky/engine/core/css/CSSImageGeneratorValue.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	sky/engine/core/css/MediaQueryList.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/css/MediaQueryMatcher.h	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	sky/engine/core/frame/ConsoleBase.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sky/engine/platform/AsyncMethodRunner.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/engine/platform/Supplementable.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	sky/engine/platform/Timer.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	sky/engine/platform/heap/Handle.h	View	3 chunks	+57 lines, -2 lines	0 comments	Download
D	sky/engine/platform/heap/Heap.h	View	1 chunk	+0 lines, -1588 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/681113004/diff/1/sky/engine/core/css/MediaQueryMatcher.h File sky/engine/core/css/MediaQueryMatcher.h (right): https://codereview.chromium.org/681113004/diff/1/sky/engine/core/css/MediaQueryMatcher.h#newcode29 sky/engine/core/css/MediaQueryMatcher.h:29: O_o

6 years, 1 month ago (2014-10-28 04:02:29 UTC) #2

eseidel

6 years, 1 month ago (2014-10-28 04:05:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0796329e3a2290575d84575248289f1ea7954e84 (presubmit successful).

Expand Messages | Collapse Messages