Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: sky/engine/platform/AsyncMethodRunner.h

Issue 681113004: Remove Heap.h (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/platform/AsyncMethodRunner.h
diff --git a/sky/engine/platform/AsyncMethodRunner.h b/sky/engine/platform/AsyncMethodRunner.h
index 700375d8eb2ffbc3fefd2ac5a3d58cf3fa226edf..9fa52b4cdc319cd8d374e4d6695289d476d65aa2 100644
--- a/sky/engine/platform/AsyncMethodRunner.h
+++ b/sky/engine/platform/AsyncMethodRunner.h
@@ -124,10 +124,6 @@ private:
Timer<AsyncMethodRunner<TargetClass> > m_timer;
- // FIXME: oilpan: AsyncMethodRunner should be moved to the heap and m_object should be traced.
- // This raw pointer is safe as long as AsyncMethodRunner<X> is held by the X itself
- // (That's the case in the current code base).
- GC_PLUGIN_IGNORE("363031")
TargetClass* m_object;
TargetMethod m_method;

Powered by Google App Engine
This is Rietveld 408576698