Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: sky/engine/platform/Timer.h

Issue 681113004: Remove Heap.h (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/platform/Timer.h
diff --git a/sky/engine/platform/Timer.h b/sky/engine/platform/Timer.h
index 7aeb2b4f9eef17cdf7737244cddf7f951b87b317..0dc1bc9e6f7f52bec20394214c333606c3f1c4ec 100644
--- a/sky/engine/platform/Timer.h
+++ b/sky/engine/platform/Timer.h
@@ -124,10 +124,6 @@ public:
private:
virtual void fired() override { (m_object->*m_function)(this); }
- // FIXME: oilpan: TimerBase should be moved to the heap and m_object should be traced.
- // This raw pointer is safe as long as Timer<X> is held by the X itself (That's the case
- // in the current code base).
- GC_PLUGIN_IGNORE("363031")
TimerFiredClass* m_object;
TimerFiredFunction m_function;
};
@@ -180,10 +176,8 @@ private:
(m_object->*m_function)(this);
}
- // FIXME: oilpan: TimerBase should be moved to the heap and m_object should be traced.
// This raw pointer is safe as long as Timer<X> is held by the X itself (That's the case
// in the current code base).
- GC_PLUGIN_IGNORE("363031")
TimerFiredClass* m_object;
TimerFiredFunction m_function;

Powered by Google App Engine
This is Rietveld 408576698