Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 68103018: Revert 234478 "Revert 234272 "Revert 234257 "Build mac and linux..." (Closed)

Created:
7 years, 1 month ago by agable
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 234478 "Revert 234272 "Revert 234257 "Build mac and linux..." This CL increases extract_build times from ~40 seconds to ~400 seconds. We are not currently equipped to handle this slowdown of build cycle times. Reverting this until we have a way to do this that won't increase cycle times by 15%. BUG=315598 TBR=jochen@chromium.org,cmp@chromium.org,dpranke@chromium.org > Revert 234272 "Revert 234257 "Build mac and linux release builds..." > > > Revert 234257 "Build mac and linux release builds with symbols a..." > > > > NaCL ignores linux_strip_binary... > > > > > Build mac and linux release builds with symbols and don't strip them by default > > > > > > On Mac, we already build with symbols, but strip them. > > > > > > Building with symbols (a) matches what we do for official builds and (b) > > > makes crashes on release builders more useful. > > > > > > BUG=315598 > > > R=mark@chromium.org, thakis@chromium.org > > > > > > Review URL: https://codereview.chromium.org/66673005 > > > > TBR=jochen@chromium.org > > > > Review URL: https://codereview.chromium.org/69493002 > > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/66293011 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M trunk/src/build/common.gypi View 3 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
agable
7 years, 1 month ago (2013-11-14 05:30:25 UTC) #1
agable
Committed patchset #1 manually as r235042.
7 years, 1 month ago (2013-11-14 05:30:32 UTC) #2
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-14 05:54:36 UTC) #3
Message was sent while issue was closed.
On 2013/11/14 05:30:32, Aaron Gable wrote:
> Committed patchset #1 manually as r235042.

not really lgtm

It would have been enough to revert the Linux specific bits. :-/

Powered by Google App Engine
This is Rietveld 408576698