Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 66673005: Build mac and linux release builds with symbols and don't strip them by default (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Build mac and linux release builds with symbols and don't strip them by default On Mac, we already build with symbols, but strip them. Building with symbols (a) matches what we do for official builds and (b) makes crashes on release builders more useful. BUG=315598 R=mark@chromium.org, thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
build/common.gypi View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-08 16:00:01 UTC) #1
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-08 16:00:02 UTC) #2
Mark Mentovai
Did you test this out with a buildtype=Official branding=Chrome build on the Mac?
7 years, 1 month ago (2013-11-08 16:36:51 UTC) #3
jochen (gone - plz use gerrit)
On 2013/11/08 16:36:51, Mark Mentovai wrote: > Did you test this out with a buildtype=Official ...
7 years, 1 month ago (2013-11-08 19:02:04 UTC) #4
jochen (gone - plz use gerrit)
On 2013/11/08 16:36:51, Mark Mentovai wrote: > Did you test this out with a buildtype=Official ...
7 years, 1 month ago (2013-11-11 12:18:59 UTC) #5
Mark Mentovai
LGTM
7 years, 1 month ago (2013-11-11 12:20:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/66673005/1
7 years, 1 month ago (2013-11-11 12:21:23 UTC) #7
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-11 19:25:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r234257 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698