Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 69493002: Revert 234257 "Build mac and linux release builds with symbols a..." (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 234257 "Build mac and linux release builds with symbols a..." NaCL ignores linux_strip_binary... > Build mac and linux release builds with symbols and don't strip them by default > > On Mac, we already build with symbols, but strip them. > > Building with symbols (a) matches what we do for official builds and (b) > makes crashes on release builders more useful. > > BUG=315598 > R=mark@chromium.org, thakis@chromium.org > > Review URL: https://codereview.chromium.org/66673005 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M trunk/src/build/common.gypi View 3 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-11 20:29:25 UTC) #1
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-11 20:29:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r234272.

Powered by Google App Engine
This is Rietveld 408576698