Issue 680973002: Revert "Accelerate the lighten blendmode if GL_EXT_blend_minmax is enabled."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 680973002: Revert "Accelerate the lighten blendmode if GL_EXT_blend_minmax is enabled." (Closed)

Created:
6 years, 1 month ago by Erik Dahlström (inactive)

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam, piman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert "Accelerate the lighten blendmode if GL_EXT_blend_minmax is enabled." This reverts https://crrev.com/fad658b4d6af2be70c1d39b98ffa92c578f31006. The 'lighten' results are incorrect if we have alpha, demonstrated by https://codereview.chromium.org/673873005/, the resulting blend equation doesn't match the one in the spec. BUG=243223 TBR=enne@chromium.org, jbauman@chromium.org, mkwst@chromium.org, rosca@adobe.com Committed: https://crrev.com/20607badde183d15907cef19ae8a4f34512e1861 Cr-Commit-Position: refs/heads/master@{#301624}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -16 lines)			Patch
M	cc/output/gl_renderer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/output/gl_renderer.cc	View	4 chunks	+0 lines, -8 lines	0 comments	Download
M	content/common/gpu/gpu_messages.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/command_buffer/common/capabilities.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/command_buffer/common/capabilities.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/feature_info.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/feature_info.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/680973002/1

6 years, 1 month ago (2014-10-28 10:26:29 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-28 12:11:37 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/20607badde183d15907cef19ae8a4f34512e1861
Cr-Commit-Position: refs/heads/master@{#301624}