Standardize usage of virtual/override/final specifiers.

Standardize usage of virtual/override/final specifiers.

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=jamescook@chromium.org

Committed: https://crrev.com/f59635116303ce62fcc95a647df72c77e0129eee
Cr-Commit-Position: refs/heads/master@{#301535}

[James Cook, 2014-10-27 23:45:35]

LGTM but two questions

https://codereview.chromium.org/679283002/diff/1/ash/shell/app_list.cc
File ash/shell/app_list.cc (right):

https://codereview.chromium.org/679283002/diff/1/ash/shell/app_list.cc#newcode58
ash/shell/app_list.cc:58: }
Do you think this class should have ~WindowTypeShelfItem() override {} ?

It doesn't strictly need it -- there are no interesting member variables here --
but that seems like a good pattern to maintain.

https://codereview.chromium.org/679283002/diff/1/ash/shell/bubble.cc
File ash/shell/bubble.cc (right):

https://codereview.chromium.org/679283002/diff/1/ash/shell/bubble.cc#newcode25
ash/shell/bubble.cc:25: label_(config.label) {}
Likewise, do you think this needs ~ExampleBubbleDelegateView() override {} ?  It
has a non-trivial member.

[dcheng, 2014-10-27 23:47:56]

https://codereview.chromium.org/679283002/diff/1/ash/shell/app_list.cc
File ash/shell/app_list.cc (right):

https://codereview.chromium.org/679283002/diff/1/ash/shell/app_list.cc#newcode58
ash/shell/app_list.cc:58: }
On 2014/10/27 23:45:34, James Cook wrote:
> Do you think this class should have ~WindowTypeShelfItem() override {} ?
> 
> It doesn't strictly need it -- there are no interesting member variables here
--
> but that seems like a good pattern to maintain.

If the clang plugin doesn't enforce it, I would argue it's optional =)

However, if you'd like me to add it, I'd be happy to do so in a followup patch.
Let me know if that's OK.

https://codereview.chromium.org/679283002/diff/1/ash/shell/bubble.cc
File ash/shell/bubble.cc (right):

https://codereview.chromium.org/679283002/diff/1/ash/shell/bubble.cc#newcode25
ash/shell/bubble.cc:25: label_(config.label) {}
On 2014/10/27 23:45:34, James Cook wrote:
> Likewise, do you think this needs ~ExampleBubbleDelegateView() override {} ? 
It
> has a non-trivial member.

Ditto.

[James Cook, 2014-10-27 23:50:14]

Please add them. A followup patch is fine, TBR is fine.

Still LGTM

Thanks for doing this cleanup!

[dcheng, 2014-10-27 23:53:14]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-10-27 23:57:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/679283002/1

[commit-bot: I haz the power, 2014-10-28 01:14:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-28 01:15:10]

Patchset 1 (id:??) landed as
https://crrev.com/f59635116303ce62fcc95a647df72c77e0129eee
Cr-Commit-Position: refs/heads/master@{#301535}