Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2315)

Unified Diff: ash/shell/bubble.cc

Issue 679283002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell/bubble.cc
diff --git a/ash/shell/bubble.cc b/ash/shell/bubble.cc
index 00e80e6792a822ede901abbea370f9fa954c5367..5c157ee1eac548a8bb12509fe23f0313e9a87ef9 100644
--- a/ash/shell/bubble.cc
+++ b/ash/shell/bubble.cc
@@ -24,7 +24,7 @@ class ExampleBubbleDelegateView : public views::BubbleDelegateView {
: BubbleDelegateView(config.anchor_view, config.arrow),
label_(config.label) {}
James Cook 2014/10/27 23:45:34 Likewise, do you think this needs ~ExampleBubbleDe
dcheng 2014/10/27 23:47:55 Ditto.
- virtual void Init() override {
+ void Init() override {
SetLayoutManager(new views::FillLayout());
views::Label* label = new views::Label(label_);
AddChildView(label);

Powered by Google App Engine
This is Rietveld 408576698