Source/core/html/HTMLInputElement.cpp - Issue 679273004: Set element value to its default value on reset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 679273004: Set element value to its default value on reset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated as missed updating one review comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 03a3844148a46536e4d8d60daeb69c47ce9ac77c..502981f2a21b67558f44efb559d1b30007567b46 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -1025,7 +1025,7 @@ void HTMLInputElement::setValue(const String& value, TextFieldEventBehavior even

m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior);

if (valueChanged && eventBehavior == DispatchNoEvent)

- setTextAsOfLastFormControlChangeEvent(sanitizedValue);

+ setTextAsOfLastFormControlChangeEvent(sanitizedValue.isNull() ? defaultValue() : sanitizedValue);

if (!valueChanged)

return;