Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 679273004: Set element value to its default value on reset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated as missed updating one review comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 String sanitizedValue = sanitizeValue(value); 1018 String sanitizedValue = sanitizeValue(value);
1019 bool valueChanged = sanitizedValue != this->value(); 1019 bool valueChanged = sanitizedValue != this->value();
1020 1020
1021 setLastChangeWasNotUserEdit(); 1021 setLastChangeWasNotUserEdit();
1022 m_needsToUpdateViewValue = true; 1022 m_needsToUpdateViewValue = true;
1023 m_suggestedValue = String(); // Prevent TextFieldInputType::setValue from us ing the suggested value. 1023 m_suggestedValue = String(); // Prevent TextFieldInputType::setValue from us ing the suggested value.
1024 1024
1025 m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior); 1025 m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior);
1026 1026
1027 if (valueChanged && eventBehavior == DispatchNoEvent) 1027 if (valueChanged && eventBehavior == DispatchNoEvent)
1028 setTextAsOfLastFormControlChangeEvent(sanitizedValue); 1028 setTextAsOfLastFormControlChangeEvent(sanitizedValue.isNull() ? defaultV alue() : sanitizedValue);
1029 1029
1030 if (!valueChanged) 1030 if (!valueChanged)
1031 return; 1031 return;
1032 1032
1033 notifyFormStateChanged(); 1033 notifyFormStateChanged();
1034 } 1034 }
1035 1035
1036 void HTMLInputElement::setValueInternal(const String& sanitizedValue, TextFieldE ventBehavior eventBehavior) 1036 void HTMLInputElement::setValueInternal(const String& sanitizedValue, TextFieldE ventBehavior eventBehavior)
1037 { 1037 {
1038 m_valueIfDirty = sanitizedValue; 1038 m_valueIfDirty = sanitizedValue;
(...skipping 818 matching lines...) Expand 10 before | Expand all | Expand 10 after
1857 void HTMLInputElement::ensurePrimaryContent() 1857 void HTMLInputElement::ensurePrimaryContent()
1858 { 1858 {
1859 m_inputTypeView->ensurePrimaryContent(); 1859 m_inputTypeView->ensurePrimaryContent();
1860 } 1860 }
1861 1861
1862 bool HTMLInputElement::hasFallbackContent() const 1862 bool HTMLInputElement::hasFallbackContent() const
1863 { 1863 {
1864 return m_inputTypeView->hasFallbackContent(); 1864 return m_inputTypeView->hasFallbackContent();
1865 } 1865 }
1866 } // namespace 1866 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698