Source/core/html/forms/TextFieldInputType.cpp - Issue 679273004: Set element value to its default value on reset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 679273004: Set element value to its default value on reset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated as missed updating one review comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/TextFieldInputType.cpp

diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp

index 135d7f9c7ca7f25b883b3fc76c6d8bc134747121..d536c93e21492a989ae169a05be0689abebf3085 100644

--- a/Source/core/html/forms/TextFieldInputType.cpp

+++ b/Source/core/html/forms/TextFieldInputType.cpp

@@ -189,7 +189,7 @@ void TextFieldInputType::setValue(const String& sanitizedValue, bool valueChange

}

if (!input->focused())

- input->setTextAsOfLastFormControlChangeEvent(sanitizedValue);

+ input->setTextAsOfLastFormControlChangeEvent(sanitizedValue.isNull() ? input->defaultValue() : sanitizedValue);

}

void TextFieldInputType::handleKeydownEvent(KeyboardEvent* event)

« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | no next file » | no next file with comments »