Source/core/html/HTMLInputElement.h - Issue 679273004: Set element value to its default value on reset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.h

Issue 679273004: Set element value to its default value on reset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added isReset as a parameter to not allow setValue change value of m_textAsOfLastFormControlChangeE… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLInputElement.h

diff --git a/Source/core/html/HTMLInputElement.h b/Source/core/html/HTMLInputElement.h

index 5fccef09af19c9d5bfd346d4373ea7bb0b392cc5..b3d2c19387a5928adc51ec10916234cd461e1ef3 100644

--- a/Source/core/html/HTMLInputElement.h

+++ b/Source/core/html/HTMLInputElement.h

@@ -108,7 +108,7 @@ public:

virtual String value() const override;

void setValue(const String&, ExceptionState&, TextFieldEventBehavior = DispatchNoEvent);

- void setValue(const String&, TextFieldEventBehavior = DispatchNoEvent);

+ void setValue(const String&, TextFieldEventBehavior = DispatchNoEvent, bool isReset = false);

tkent 2014/11/06 00:11:16 Please do not add new bool argument to a public fu

Habib Virji 2014/11/06 14:23:08 Acknowledged.

void setValueForUser(const String&);

// Checks if the specified string would be a valid value.

// We should not call this for types with no string value such as CHECKBOX and RADIO.