Set element value to its default value on reset

Source/core/html/HTMLInputElement.cpp

Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index d0704564663d4357c2add46e8a78209cd188920e..e021d95f01f13d01231d84efcce40d9cfc6d7c2c 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -839,7 +839,7 @@ String HTMLInputElement::resultForDialogSubmit()
 void HTMLInputElement::resetImpl()
 {
     if (m_inputType->storesValueSeparateFromAttribute()) {
-        setValue(String());
+        setValue(String(), DispatchNoEvent, true);
         setNeedsValidityCheck();
     }
 
@@ -1009,7 +1009,7 @@ void HTMLInputElement::setValue(const String& value, ExceptionState& exceptionSt
     setValue(value, eventBehavior);
 }
 
-void HTMLInputElement::setValue(const String& value, TextFieldEventBehavior eventBehavior)
+void HTMLInputElement::setValue(const String& value, TextFieldEventBehavior eventBehavior, bool isReset)
 {
     m_inputType->warnIfValueIsInvalidAndElementIsVisible(value);
     if (!m_inputType->canSetValue(value))
@@ -1024,9 +1024,9 @@ void HTMLInputElement::setValue(const String& value, TextFieldEventBehavior even
     m_needsToUpdateViewValue = true;
     m_suggestedValue = String(); // Prevent TextFieldInputType::setValue from using the suggested value.
 
-    m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior);
+    m_inputType->setValue(sanitizedValue, valueChanged, isReset, eventBehavior);
 
-    if (valueChanged && eventBehavior == DispatchNoEvent)
+    if (valueChanged && eventBehavior == DispatchNoEvent && !isReset)

[tkent, 2014/11/06 00:11:16]

Skipping setTextAsOfLastFormControlChangeEvent doesn't look correct.  What
should be set to m_extAsOfLastFormControlChangeEvent in the reset case?

[Habib Virji, 2014/11/06 14:23:08]

<input type=text value=seed>
During HTMLParsing, value of m_textAsOfLastFormControlChangeEvent is set to
"seed", the value of the element. 

On reset, value of m_textAsOfLastFormControlChangeEvent is set to "", because
reset setValue to null string.

So when the element value after reset, if changed to "", although it  displays
"seed", but m_textAsOfLastFormControlChangeEvent value is "", so no change event
is discharged.  

I was trying to get value of m_textAsLastFromControlChangeEvent, not to change
during reset. Changing value of m_textAsOfLastFormControlChangeEvent, when no
change event is to be discharged, also looks bit unappropriate during reset. 

[tkent, 2014/11/07 00:34:19]

Ok, HTMLTextFormControlElement::insertedInto() does it.
Well, skipping setTextAsOfLastFormControlChangeEvent is wrong. If we skipped it,
it would have a value before reset().
m_textAsOfLastFormControlChangeEvent should be consistent with the parsing case.
 So, it should have defaultValue().
How about changing the next line to the following?
    setTextAsOfLastFormControlChangeEvent(sanitizedValue.isNull() ? value() :
sanitizedValue);

[Habib Virji, 2014/11/07 14:10:43]

Thanks above suggested change does work and looks more appropriate. I have use
defaultValue() instead of value(), as that's the available function that gives
same value as parsing. Also the value in the textField sets to visibleValue().

         setTextAsOfLastFormControlChangeEvent(sanitizedValue);
 
     if (!valueChanged)