Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: Source/core/html/HTMLInputElement.h

Issue 679273004: Set element value to its default value on reset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added isReset as a parameter to not allow setValue change value of m_textAsOfLastFormControlChangeE… Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 bool shouldAppearChecked() const; 101 bool shouldAppearChecked() const;
102 virtual bool shouldAppearIndeterminate() const override; 102 virtual bool shouldAppearIndeterminate() const override;
103 103
104 int size() const; 104 int size() const;
105 bool sizeShouldIncludeDecoration(int& preferredSize) const; 105 bool sizeShouldIncludeDecoration(int& preferredSize) const;
106 106
107 void setType(const AtomicString&); 107 void setType(const AtomicString&);
108 108
109 virtual String value() const override; 109 virtual String value() const override;
110 void setValue(const String&, ExceptionState&, TextFieldEventBehavior = Dispa tchNoEvent); 110 void setValue(const String&, ExceptionState&, TextFieldEventBehavior = Dispa tchNoEvent);
111 void setValue(const String&, TextFieldEventBehavior = DispatchNoEvent); 111 void setValue(const String&, TextFieldEventBehavior = DispatchNoEvent, bool isReset = false);
tkent 2014/11/06 00:11:16 Please do not add new bool argument to a public fu
Habib Virji 2014/11/06 14:23:08 Acknowledged.
112 void setValueForUser(const String&); 112 void setValueForUser(const String&);
113 // Checks if the specified string would be a valid value. 113 // Checks if the specified string would be a valid value.
114 // We should not call this for types with no string value such as CHECKBOX a nd RADIO. 114 // We should not call this for types with no string value such as CHECKBOX a nd RADIO.
115 bool isValidValue(const String&) const; 115 bool isValidValue(const String&) const;
116 bool hasDirtyValue() const { return !m_valueIfDirty.isNull(); }; 116 bool hasDirtyValue() const { return !m_valueIfDirty.isNull(); };
117 117
118 String sanitizeValue(const String&) const; 118 String sanitizeValue(const String&) const;
119 119
120 String localizeValue(const String&) const; 120 String localizeValue(const String&) const;
121 121
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 // The ImageLoader must be owned by this element because the loader code ass umes 379 // The ImageLoader must be owned by this element because the loader code ass umes
380 // that it lives as long as its owning element lives. If we move the loader into 380 // that it lives as long as its owning element lives. If we move the loader into
381 // the ImageInput object we may delete the loader while this element lives o n. 381 // the ImageInput object we may delete the loader while this element lives o n.
382 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader; 382 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader;
383 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r; 383 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r;
384 }; 384 };
385 385
386 } // namespace blink 386 } // namespace blink
387 387
388 #endif // HTMLInputElement_h 388 #endif // HTMLInputElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698