Set element value to its default value on reset

Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
@@ skipping 821 matching lines @@
 }
 
 String HTMLInputElement::resultForDialogSubmit()
 {
     return m_inputType->resultForDialogSubmit();
 }
 
 void HTMLInputElement::resetImpl()
 {
     if (m_inputType->storesValueSeparateFromAttribute()) {
-        setValue(String());
+        setValue(String(), DispatchNoEvent, true);
         setNeedsValidityCheck();
     }
 
     setChecked(hasAttribute(checkedAttr));
     m_reflectsCheckedAttribute = true;
 }
 
 bool HTMLInputElement::isTextField() const
 {
     return m_inputType->isTextField();
@@ skipping 149 matching lines @@
 void HTMLInputElement::setValue(const String& value, ExceptionState& exceptionState, TextFieldEventBehavior eventBehavior)
 {
     // FIXME: Remove type check.
     if (type() == InputTypeNames::file && !value.isEmpty()) {
         exceptionState.throwDOMException(InvalidStateError, "This input element accepts a filename, which may only be programmatically set to the empty string.");
         return;
     }
     setValue(value, eventBehavior);
 }
 
-void HTMLInputElement::setValue(const String& value, TextFieldEventBehavior eventBehavior)
+void HTMLInputElement::setValue(const String& value, TextFieldEventBehavior eventBehavior, bool isReset)
 {
     m_inputType->warnIfValueIsInvalidAndElementIsVisible(value);
     if (!m_inputType->canSetValue(value))
         return;
 
     RefPtrWillBeRawPtr<HTMLInputElement> protector(this);
     EventQueueScope scope;
     String sanitizedValue = sanitizeValue(value);
     bool valueChanged = sanitizedValue != this->value();
 
     setLastChangeWasNotUserEdit();
     m_needsToUpdateViewValue = true;
     m_suggestedValue = String(); // Prevent TextFieldInputType::setValue from using the suggested value.
 
-    m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior);
+    m_inputType->setValue(sanitizedValue, valueChanged, isReset, eventBehavior);
 
-    if (valueChanged && eventBehavior == DispatchNoEvent)
+    if (valueChanged && eventBehavior == DispatchNoEvent && !isReset)

[tkent, 2014/11/06 00:11:16]

Skipping setTextAsOfLastFormControlChangeEvent doesn't look correct.  What
should be set to m_extAsOfLastFormControlChangeEvent in the reset case?

[Habib Virji, 2014/11/06 14:23:08]

<input type=text value=seed>
During HTMLParsing, value of m_textAsOfLastFormControlChangeEvent is set to
"seed", the value of the element. 

On reset, value of m_textAsOfLastFormControlChangeEvent is set to "", because
reset setValue to null string.

So when the element value after reset, if changed to "", although it  displays
"seed", but m_textAsOfLastFormControlChangeEvent value is "", so no change event
is discharged.  

I was trying to get value of m_textAsLastFromControlChangeEvent, not to change
during reset. Changing value of m_textAsOfLastFormControlChangeEvent, when no
change event is to be discharged, also looks bit unappropriate during reset. 

[tkent, 2014/11/07 00:34:19]

Ok, HTMLTextFormControlElement::insertedInto() does it.
Well, skipping setTextAsOfLastFormControlChangeEvent is wrong. If we skipped it,
it would have a value before reset().
m_textAsOfLastFormControlChangeEvent should be consistent with the parsing case.
 So, it should have defaultValue().
How about changing the next line to the following?
    setTextAsOfLastFormControlChangeEvent(sanitizedValue.isNull() ? value() :
sanitizedValue);

[Habib Virji, 2014/11/07 14:10:43]

Thanks above suggested change does work and looks more appropriate. I have use
defaultValue() instead of value(), as that's the available function that gives
same value as parsing. Also the value in the textField sets to visibleValue().

         setTextAsOfLastFormControlChangeEvent(sanitizedValue);
 
     if (!valueChanged)
         return;
 
     notifyFormStateChanged();
 }
 
 void HTMLInputElement::setValueInternal(const String& sanitizedValue, TextFieldEventBehavior eventBehavior)
 {
@@ skipping 807 matching lines @@
 {
     listAttributeTargetChanged();
 }
 
 AXObject* HTMLInputElement::popupRootAXObject()
 {
     return m_inputTypeView->popupRootAXObject();
 }
 
 } // namespace