Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 678843002: Revert of Enable Service Workers, including the onfetch event, by default. (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
CC:
blink-reviews, dmurph, falken, horo, jakeachibald_chromium.org, jsbell, kenjibaheux, kinuko, Kunihiko Sakamoto, michaeln, nhiroki, slightlyoff
Project:
blink
Visibility:
Public.

Description

Revert of Enable Service Workers, including the onfetch event, by default. (patchset #1 id:1 of https://codereview.chromium.org/680473002/) Reason for revert: Directory restriction of ServiceWorker sope patch (https://codereview.chromium.org/672383003/) is reverted. We should not enable ServiceWorker without this restriction for security reason. I will revert this patch after these patches will land. [1/3 blink] https://codereview.chromium.org/674133004/ Update LayoutTests to be subject to the directory restrictions. [2/3 chromium] https://codereview.chromium.org/674133004/ Introduce the directory restriction in Chromium side. [3/3 blink] https://codereview.chromium.org/681483004/ Introduce the directory restriction in Blink side and update LayoutTest. Original issue's description: > Enable Service Workers, including the onfetch event, by default. > > BUG=364627 > TEST=virtual/stable/webexposed > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184340 TBR=jochen@chromium.org,tkent@chromium.org,falken@chromium.org,dominicc@chromium.org NOTREECHECKS=true NOTRY=true BUG=364627 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184400

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
horo
Created Revert of Enable Service Workers, including the onfetch event, by default.
6 years, 1 month ago (2014-10-25 00:34:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678843002/1
6 years, 1 month ago (2014-10-25 00:35:20 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/platform/RuntimeEnabledFeatures.in: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-10-25 00:35:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678843002/70001
6 years, 1 month ago (2014-10-25 01:35:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:70001) as 184400
6 years, 1 month ago (2014-10-25 01:36:19 UTC) #7
horo
6 years, 1 month ago (2014-10-26 01:27:06 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:70001) has been created in
https://codereview.chromium.org/680643004/ by horo@chromium.org.

The reason for reverting is: It is ok to enable SW.
We will fix this issue before launch..

Powered by Google App Engine
This is Rietveld 408576698