Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 677843004: Remove text-combine. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove text-combine. This is a vertical writing mode feature. Sky doesn't support vertical writing mode. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1c4fd195b195f26c97f3b3cb6f956037ea37e91a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -287 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -30 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Text.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/InlineTextBox.cpp View 8 chunks +11 lines, -35 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/engine/core/rendering/RenderCombineText.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/core/rendering/RenderCombineText.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
M sky/engine/core/rendering/RenderText.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/line/BreakingContextInlineHeaders.h View 4 chunks +1 line, -18 lines 0 comments Download
M sky/engine/core/rendering/line/LineBreaker.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-10-30 02:26:58 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-10-30 02:29:19 UTC) #3
ojan
6 years, 1 month ago (2014-10-30 02:30:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1c4fd195b195f26c97f3b3cb6f956037ea37e91a.

Powered by Google App Engine
This is Rietveld 408576698