sky/engine/core/rendering/RenderBlockFlow.h - Issue 677843004: Remove text-combine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBlockFlow.h

Issue 677843004: Remove text-combine. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBlockFlow.h

diff --git a/sky/engine/core/rendering/RenderBlockFlow.h b/sky/engine/core/rendering/RenderBlockFlow.h

index b7879a1ef6988d8a11fe8ffa675625d29d0c1ff4..e3fc806eebe397df2d806bb599279186bded8f4d 100644

--- a/sky/engine/core/rendering/RenderBlockFlow.h

+++ b/sky/engine/core/rendering/RenderBlockFlow.h

@@ -123,7 +123,7 @@ public:

void addOverflowFromInlineChildren();

- // FIXME: This should be const to avoid a const_cast, but can modify child dirty bits and RenderCombineText

+ // FIXME: This should be const to avoid a const_cast, but can modify child dirty bits

void computeInlinePreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth);

GapRects inlineSelectionGaps(RenderBlock* rootBlock, const LayoutPoint& rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock,