Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: sky/engine/core/rendering/style/RenderStyle.cpp

Issue 677843004: Remove text-combine. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 StyleRecalcChange RenderStyle::stylePropagationDiff(const RenderStyle* oldStyle, const RenderStyle* newStyle) 143 StyleRecalcChange RenderStyle::stylePropagationDiff(const RenderStyle* oldStyle, const RenderStyle* newStyle)
144 { 144 {
145 if ((!oldStyle && newStyle) || (oldStyle && !newStyle)) 145 if ((!oldStyle && newStyle) || (oldStyle && !newStyle))
146 return Reattach; 146 return Reattach;
147 147
148 if (!oldStyle && !newStyle) 148 if (!oldStyle && !newStyle)
149 return NoChange; 149 return NoChange;
150 150
151 if (oldStyle->display() != newStyle->display() 151 if (oldStyle->display() != newStyle->display()
152 || !oldStyle->contentDataEquivalent(newStyle) 152 || !oldStyle->contentDataEquivalent(newStyle)
153 || oldStyle->hasTextCombine() != newStyle->hasTextCombine()
154 || oldStyle->justifyItems() != newStyle->justifyItems() 153 || oldStyle->justifyItems() != newStyle->justifyItems()
155 || oldStyle->alignItems() != newStyle->alignItems()) 154 || oldStyle->alignItems() != newStyle->alignItems())
156 return Reattach; 155 return Reattach;
157 156
158 if (*oldStyle == *newStyle) 157 if (*oldStyle == *newStyle)
159 return NoChange; 158 return NoChange;
160 159
161 if (oldStyle->inheritedNotEqual(newStyle) 160 if (oldStyle->inheritedNotEqual(newStyle)
162 || oldStyle->hasExplicitlyInheritedProperties() 161 || oldStyle->hasExplicitlyInheritedProperties()
163 || newStyle->hasExplicitlyInheritedProperties()) 162 || newStyle->hasExplicitlyInheritedProperties())
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 || rareNonInheritedData->m_wrapFlow != other.rareNonInheritedData->m _wrapFlow 333 || rareNonInheritedData->m_wrapFlow != other.rareNonInheritedData->m _wrapFlow
335 || rareNonInheritedData->m_wrapThrough != other.rareNonInheritedData ->m_wrapThrough 334 || rareNonInheritedData->m_wrapThrough != other.rareNonInheritedData ->m_wrapThrough
336 || rareNonInheritedData->m_shapeMargin != other.rareNonInheritedData ->m_shapeMargin 335 || rareNonInheritedData->m_shapeMargin != other.rareNonInheritedData ->m_shapeMargin
337 || rareNonInheritedData->m_order != other.rareNonInheritedData->m_or der 336 || rareNonInheritedData->m_order != other.rareNonInheritedData->m_or der
338 || rareNonInheritedData->m_alignContent != other.rareNonInheritedDat a->m_alignContent 337 || rareNonInheritedData->m_alignContent != other.rareNonInheritedDat a->m_alignContent
339 || rareNonInheritedData->m_alignItems != other.rareNonInheritedData- >m_alignItems 338 || rareNonInheritedData->m_alignItems != other.rareNonInheritedData- >m_alignItems
340 || rareNonInheritedData->m_alignSelf != other.rareNonInheritedData-> m_alignSelf 339 || rareNonInheritedData->m_alignSelf != other.rareNonInheritedData-> m_alignSelf
341 || rareNonInheritedData->m_justifyContent != other.rareNonInheritedD ata->m_justifyContent 340 || rareNonInheritedData->m_justifyContent != other.rareNonInheritedD ata->m_justifyContent
342 || rareNonInheritedData->m_grid.get() != other.rareNonInheritedData- >m_grid.get() 341 || rareNonInheritedData->m_grid.get() != other.rareNonInheritedData- >m_grid.get()
343 || rareNonInheritedData->m_gridItem.get() != other.rareNonInheritedD ata->m_gridItem.get() 342 || rareNonInheritedData->m_gridItem.get() != other.rareNonInheritedD ata->m_gridItem.get()
344 || rareNonInheritedData->m_textCombine != other.rareNonInheritedData ->m_textCombine
345 || rareNonInheritedData->hasFilters() != other.rareNonInheritedData- >hasFilters()) 343 || rareNonInheritedData->hasFilters() != other.rareNonInheritedData- >hasFilters())
346 return true; 344 return true;
347 345
348 if (rareNonInheritedData->m_flexibleBox.get() != other.rareNonInheritedD ata->m_flexibleBox.get() 346 if (rareNonInheritedData->m_flexibleBox.get() != other.rareNonInheritedD ata->m_flexibleBox.get()
349 && *rareNonInheritedData->m_flexibleBox.get() != *other.rareNonInher itedData->m_flexibleBox.get()) 347 && *rareNonInheritedData->m_flexibleBox.get() != *other.rareNonInher itedData->m_flexibleBox.get())
350 return true; 348 return true;
351 349
352 // FIXME: We should add an optimized form of layout that just recomputes visual overflow. 350 // FIXME: We should add an optimized form of layout that just recomputes visual overflow.
353 if (!rareNonInheritedData->shadowDataEquivalent(*other.rareNonInheritedD ata.get())) 351 if (!rareNonInheritedData->shadowDataEquivalent(*other.rareNonInheritedD ata.get()))
354 return true; 352 return true;
(...skipping 1033 matching lines...) Expand 10 before | Expand all | Expand 10 after
1388 // right 1386 // right
1389 radiiSum = radii.topRight().height() + radii.bottomRight().height(); 1387 radiiSum = radii.topRight().height() + radii.bottomRight().height();
1390 if (radiiSum > rect.height()) 1388 if (radiiSum > rect.height())
1391 factor = std::min(rect.height() / radiiSum, factor); 1389 factor = std::min(rect.height() / radiiSum, factor);
1392 1390
1393 ASSERT(factor <= 1); 1391 ASSERT(factor <= 1);
1394 return factor; 1392 return factor;
1395 } 1393 }
1396 1394
1397 } // namespace blink 1395 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.h ('k') | sky/engine/core/rendering/style/RenderStyleConstants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698