Clip mask manager sets stencil on draw type

Clip mask manager sets stencil on draw type

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7afb5aa201e4b59397cbd8480e121d7501a227e7

Committed: https://skia.googlesource.com/skia/+/a58fe35fdae3481cf43062f7032820c320c3d163

[joshualitt, 2014-10-24 18:54:23]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[bsalomon, 2014-10-24 21:04:38]

https://codereview.chromium.org/676983003/diff/20001/src/gpu/GrClipMaskManage...
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.chromium.org/676983003/diff/20001/src/gpu/GrClipMaskManage...
src/gpu/GrClipMaskManager.cpp:250: ignoreClip = clipSpaceIBounds ==
clipSpaceRTIBounds;
Does this get respected anymore now that the if (ignoreClip) was moved above?

https://codereview.chromium.org/676983003/diff/20001/src/gpu/GrDrawState.h
File src/gpu/GrDrawState.h (right):

https://codereview.chromium.org/676983003/diff/20001/src/gpu/GrDrawState.h#ne...
src/gpu/GrDrawState.h:357: : fDrawState(NULL) {}
can put the two cons each on one line if you want

https://codereview.chromium.org/676983003/diff/20001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/676983003/diff/20001/src/gpu/gl/GrGpuGL.cpp#n...
src/gpu/gl/GrGpuGL.cpp:1907: void GrGpuGL::flushStencil(const GrOptDrawState&
optState, DrawType type) {
might make sense to just pass stencil settings object here in case we ever want
to create and set a temporary stencil state on the stack withing the gpu object.

[joshualitt, 2014-10-24 21:14:51]

feedback incorporated

[bsalomon, 2014-10-27 13:31:35]

lgtm

I think we need to get this guy operating on a passed in GrDrawState rather than
fGpu's.

[joshualitt, 2014-10-27 14:09:14]

On 2014/10/27 13:31:35, bsalomon wrote:
> lgtm
> 
> I think we need to get this guy operating on a passed in GrDrawState rather
than
> fGpu's.

Yea, let me move it up the stack to drawtarget and then I will do that.

[joshualitt, 2014-10-27 14:09:18]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-10-27 14:09:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676983003/40001

[commit-bot: I haz the power, 2014-10-27 14:17:22]

Committed patchset #3 (id:40001) as 7afb5aa201e4b59397cbd8480e121d7501a227e7

[joshualitt, 2014-10-27 14:37:15]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/678843003/ by joshualitt@google.com.

The reason for reverting is: seems to cause a gm issue on windows..

[joshualitt, 2014-10-27 15:30:05]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-10-27 15:30:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/676983003/60001

[commit-bot: I haz the power, 2014-10-27 15:39:10]

Committed patchset #4 (id:60001) as a58fe35fdae3481cf43062f7032820c320c3d163