Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: src/gpu/GrGpu.h

Issue 676983003: Clip mask manager sets stencil on draw type (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: bug fix Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrDrawState.h ('k') | src/gpu/GrGpu.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrGpu.h
diff --git a/src/gpu/GrGpu.h b/src/gpu/GrGpu.h
index e4669a25c506fa30baee1349a9d86b1822186ce8..cb146969827305089f13f987b7c01534f3e9b2f7 100644
--- a/src/gpu/GrGpu.h
+++ b/src/gpu/GrGpu.h
@@ -306,18 +306,6 @@ public:
}
void disableScissor() { fScissorState.fEnabled = false; }
- /**
- * Like the scissor methods above this is called by setupClipping and
- * should be flushed by the GrGpu subclass in flushGraphicsState. These
- * stencil settings should be used in place of those on the GrDrawState.
- * They have been adjusted to account for any interactions between the
- * GrDrawState's stencil settings and stencil clipping.
- */
- void setStencilSettings(const GrStencilSettings& settings) {
- fStencilSettings = settings;
- }
- void disableStencil() { fStencilSettings.setDisabled(); }
-
// GrGpu subclass sets clip bit in the stencil buffer. The subclass is
// free to clear the remaining bits to zero if masked clears are more
// expensive than clearing all bits.
@@ -369,7 +357,7 @@ protected:
// prepares clip flushes gpu state before a draw
bool setupClipAndFlushState(DrawType,
const GrDeviceCoordTexture* dstCopy,
- GrDrawState::AutoRestoreEffects* are,
+ GrDrawState::AutoRestoreEffects*,
const SkRect* devBounds);
// Functions used to map clip-respecting stencil tests into normal
@@ -404,9 +392,6 @@ protected:
SkIRect fRect;
} fScissorState;
- // The final stencil settings to use as determined by the clip manager.
- GrStencilSettings fStencilSettings;
-
// Helpers for setting up geometry state
void finalizeReservedVertices();
void finalizeReservedIndices();
« no previous file with comments | « src/gpu/GrDrawState.h ('k') | src/gpu/GrGpu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698