Issue 676813002: athena: Replace NOTREACHED with NOTIMPLEMENTED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 676813002: athena: Replace NOTREACHED with NOTIMPLEMENTED. (Closed)

Created:
6 years, 2 months ago by sadrul

Modified:
6 years, 1 month ago

Reviewers:
benwells, oshima

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

athena: Replace NOTREACHED with NOTIMPLEMENTED. Some extensions that uses the chrome.tabs API can end up crashing athena because of the NOTREACHED. So replace these with NOTIMPLEMENTED instead. BUG=none R=benwells@chromium.org, oshima@chromium.org Committed: https://crrev.com/311f5222c1595f59f4af626d4b7d68296abf3f16 Cr-Commit-Position: refs/heads/master@{#301359}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/extensions/extension_tab_util_athena.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/311f5222c1595f59f4af626d4b7d68296abf3f16 Cr-Commit-Position: refs/heads/master@{#301359}

6 years, 1 month ago (2014-10-27 14:15:27 UTC) #7

sadrul

6 years, 1 month ago (2014-10-27 14:15:29 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
311f5222c1595f59f4af626d4b7d68296abf3f16 (presubmit successful).